linux-kernel - Re: [PATCH] usb: gadget: aspeed_udc: use the defined variable to simplify code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024090325-thud-penalty-0283@gregkh>
Date: Tue, 3 Sep 2024 14:59:31 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: tangbin <tangbin@...s.chinamobile.com>
Cc: neal_liu@...eedtech.com, joel@....id.au, andrew@...econstruct.com.au,
	linux-aspeed@...ts.ozlabs.org, linux-usb@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: aspeed_udc: use the defined variable to
 simplify code

On Tue, Sep 03, 2024 at 08:31:52PM +0800, tangbin wrote:
> Use the defined variable 'dev' to make the code cleaner.
> 
> Signed-off-by: tangbin <tangbin@...s.chinamobile.com>

Please use your full name, not your email alias.

> ---
>  drivers/usb/gadget/udc/aspeed_udc.c | 26 +++++++++++++-------------
>  1 file changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/usb/gadget/udc/aspeed_udc.c b/drivers/usb/gadget/udc/aspeed_udc.c
> index f4781e611..702d4806c 100644
> --- a/drivers/usb/gadget/udc/aspeed_udc.c
> +++ b/drivers/usb/gadget/udc/aspeed_udc.c
> @@ -1479,7 +1479,7 @@ static int ast_udc_probe(struct platform_device *pdev)
>  	struct ast_udc_dev *udc;
>  	int rc;
>  
> -	udc = devm_kzalloc(&pdev->dev, sizeof(struct ast_udc_dev), GFP_KERNEL);
> +	udc = devm_kzalloc(dev, sizeof(struct ast_udc_dev), GFP_KERNEL);

<snip>

I see the goal, but unless you have this hardware and can test this
change out, I'm going to leave it as-is as nothing should have been
changed here.

sorry,

greg k-h