linux-kernel - Re: [PATCH v4 0/4] selftests: Fix cpuid / vendor checking build issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d2a4ca5c-3352-e570-687c-9d7ec90dbe33@linux.intel.com>
Date: Wed, 4 Sep 2024 15:18:09 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Shuah Khan <skhan@...uxfoundation.org>
cc: Muhammad Usama Anjum <usama.anjum@...labora.com>, 
    Shuah Khan <shuah@...nel.org>, Reinette Chatre <reinette.chatre@...el.com>, 
    linux-kselftest@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, 
    Shaopeng Tan <tan.shaopeng@...fujitsu.com>, 
    Fenghua Yu <fenghua.yu@...el.com>, 
    Maciej Wieczór-Retman <maciej.wieczor-retman@...el.com>
Subject: Re: [PATCH v4 0/4] selftests: Fix cpuid / vendor checking build
 issues

On Tue, 3 Sep 2024, Shuah Khan wrote:

> On 9/3/24 08:45, Ilpo Järvinen wrote:
> > This series first generalizes resctrl selftest non-contiguous CAT check
> > to not assume non-AMD vendor implies Intel. Second, it improves
> > selftests such that the use of __cpuid_count() does not lead into a
> > build failure (happens at least on ARM).
> > 
> > While ARM does not currently support resctrl features, there's an
> > ongoing work to enable resctrl support also for it on the kernel side.
> > In any case, a common header such as kselftest.h should have a proper
> > fallback in place for what it provides, thus it seems justified to fix
> > this common level problem on the common level rather than e.g.
> > disabling build for resctrl selftest for archs lacking resctrl support.
> > 
> > I've dropped reviewed and tested by tags from the last patch in v3 due
> > to major changes into the makefile logic. So it would be helpful if
> > Muhammad could retest with this version.
> > 
> > Acquiring ARCH in lib.mk will likely allow some cleanup into some
> > subdirectory makefiles but that is left as future work because this
> > series focuses in fixing cpuid/build.
> 
> > 
> > v4:
> > - New patch to reorder x86 selftest makefile to avoid clobbering CFLAGS
> >    (would cause __cpuid_count() related build fail otherwise)
> > 
> I don't like the way this patch series is mushrooming. I am not
> convinced that changes to lib.mk and x86 Makefile are necessary.

I didn't like it either what I found from the various makefiles. I think 
there are many things done which conflict with what lib.mk seems to try to 
do.

I tried to ask in the first submission what test I should use in the 
header file as I'm not very familiar with how arch specific is done in 
userspace in the first place nor how it should be done within kselftest 
framework.

> I will take a look at this to see if this can be simplified.

Sure, thanks.

-- 
 i.