linux-kernel - Re: [PATCH] ASoC/HDA cs35l56: Remove redundant IRQ handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e1aeb66c-ecb3-4778-b306-f3a212caf879@sirena.org.uk>
Date: Wed, 4 Sep 2024 13:25:04 +0100
From: Mark Brown <broonie@...nel.org>
To: Simon Trimmer <simont@...nsource.cirrus.com>
Cc: tiwai@...e.com, linux-sound@...r.kernel.org,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	patches@...nsource.cirrus.com
Subject: Re: [PATCH] ASoC/HDA cs35l56: Remove redundant IRQ handling

On Wed, Sep 04, 2024 at 12:07:00PM +0000, Simon Trimmer wrote:
> The IRQ handling in the cs35l56 driver was purely informational. It was
> not necessary to support the HDA or ASoC driver functionality and added
> unnecessary complexity to the drivers.
> 
> As the IRQ signal GPIO line could be connected and shared with other
> components the handling is replaced with a regmap patch to ensure the
> cs35l56 IRQ sources are masked and will not generate interrupts that go
> unhandled.

Given that the code is there now and has been since the driver was
introduced about 18 months ago what's the ongoing cost of having it?
The information it's providing is notification of hardware faults,
reporting those does seem useful.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)