linux-kernel - Re: [PATCH v6 26/26] MAINTAINERS: add entry for the Rust `alloc` module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f99d8d3a-5b56-4555-a1fc-bd7685dcea40@proton.me>
Date: Wed, 04 Sep 2024 12:51:34 +0000
From: Benno Lossin <benno.lossin@...ton.me>
To: Alice Ryhl <aliceryhl@...gle.com>, Danilo Krummrich <dakr@...nel.org>
Cc: Gary Guo <gary@...yguo.net>, ojeda@...nel.org, alex.gaynor@...il.com, wedsonaf@...il.com, boqun.feng@...il.com, bjorn3_gh@...tonmail.com, a.hindborg@...sung.com, akpm@...ux-foundation.org, daniel.almeida@...labora.com, faith.ekstrand@...labora.com, boris.brezillon@...labora.com, lina@...hilina.net, mcanal@...lia.com, zhiw@...dia.com, cjia@...dia.com, jhubbard@...dia.com, airlied@...hat.com, ajanulgu@...hat.com, lyude@...hat.com, linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH v6 26/26] MAINTAINERS: add entry for the Rust `alloc` module

On 04.09.24 12:15, Alice Ryhl wrote:
> On Tue, Sep 3, 2024 at 2:03 PM Danilo Krummrich <dakr@...nel.org> wrote:
>>
>> On Sat, Aug 31, 2024 at 01:57:12PM +0100, Gary Guo wrote:
>>> On Fri, 16 Aug 2024 02:11:08 +0200
>>> Danilo Krummrich <dakr@...nel.org> wrote:
>>>
>>>> Add maintainers entry for the Rust `alloc` module.
>>>>
>>>> Currently, this includes the `Allocator` API itself, `Allocator`
>>>> implementations, such as `Kmalloc` or `Vmalloc`, as well as the kernel's
>>>> implementation of the primary memory allocation data structures, `Box`
>>>> and `Vec`.
>>>>
>>>> Signed-off-by: Danilo Krummrich <dakr@...nel.org>
>>>> ---
>>>>  MAINTAINERS | 7 +++++++
>>>>  1 file changed, 7 insertions(+)
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index 42decde38320..560516b3aaf4 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -19925,6 +19925,13 @@ F: scripts/*rust*
>>>>  F: tools/testing/selftests/rust/
>>>>  K: \b(?i:rust)\b
>>>>
>>>> +RUST [ALLOC]
>>>> +M: Danilo Krummrich <dakr@...nel.org>
>>>> +L: rust-for-linux@...r.kernel.org
>>>> +S: Maintained
>>>> +F: rust/kernel/alloc.rs
>>>> +F: rust/kernel/alloc/
>>>
>>> It feels like we should use `mod.rs`.
>>
>> The same would be true for:
>>
>> - rust/kernel/sync.rs
>> - rust/kernel/net.rs
>> - rust/kernel/init.rs
>> - rust/kernel/fs.rs
>> - ...
>>
>> Do you propose to change it for all of them?
> 
> I do actually think `mod.rs` is superior in general, but it's probably
> not worth changing it right now.

I forgot the reason for not using it, does anyone remember?

---
Cheers,
Benno