linux-kernel - Re: [PATCH v2 1/1] media: i2c: max96717: add test pattern ctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZthatrCgOKDwP7Ro@kekkonen.localdomain>
Date: Wed, 4 Sep 2024 13:03:50 +0000
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Tommaso Merciai <tomm.merciai@...il.com>
Cc: linuxfancy@...glegroups.com, michael.roeder@...et.eu,
	julien.massot@...labora.com,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] media: i2c: max96717: add test pattern ctrl

Hi Tommaso,

On Wed, Sep 04, 2024 at 03:01:36PM +0200, Tommaso Merciai wrote:
> On Wed, Sep 04, 2024 at 02:53:55PM +0200, Tommaso Merciai wrote:
> > Hi Sakari,
> > Sorry for delay and thanks for reviewing this.

No problem.

> > 
> > On Wed, Aug 28, 2024 at 06:44:19AM +0000, Sakari Ailus wrote:
> > > >  	priv->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE | V4L2_SUBDEV_FL_STREAMS;
> > > 
> > > With controls, you should add the HAS_EVENTS flag.
> > > 
> > > I'll take this one as we're in rc5 already, please address these in a
> > > separate patch.
> > 
> > 
> > Will send a patch for this. 
> > I think we should fix that also into max96717 driver or I'm wrong?
> 
> max96714 sorry.

Yes, please.

-- 
Kind regards,

Sakari Ailus