linux-kernel - Re: [PATCH] mailbox: Use of_property_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqJFT1y6+LkVUOYhGqTN=1jYescxTbSFGLfu8zrO2ijLSg@mail.gmail.com>
Date: Wed, 4 Sep 2024 08:20:22 -0500
From: Rob Herring <robh@...nel.org>
To: Jassi Brar <jassisinghbrar@...il.com>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mailbox: Use of_property_match_string() instead of open-coding

On Tue, Sep 3, 2024 at 4:05 PM Jassi Brar <jassisinghbrar@...il.com> wrote:
>
> On Tue, Sep 3, 2024 at 2:18 PM Rob Herring <robh@...nel.org> wrote:
> >
> > On Wed, Jul 31, 2024 at 3:16 PM Rob Herring (Arm) <robh@...nel.org> wrote:
> > >
> > > Use of_property_match_string() instead of open-coding the search. With
> > > this, of_get_property() can be removed as there is no need to check for
> > > "mbox-names" presence first.
> > >
> > > This is part of a larger effort to remove callers of of_get_property()
> > > and similar functions. of_get_property() leaks the DT property data
> > > pointer which is a problem for dynamically allocated nodes which may
> > > be freed.
> > >
> > > Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> > > ---
> > >  drivers/mailbox/mailbox.c | 22 ++++++----------------
> > >  1 file changed, 6 insertions(+), 16 deletions(-)
> >
> > Ping!
> >
> Acked-by: Jassi Brar <jassisinghbrar@...il.com>

Don't need an ack, are you going to apply?

Rob