linux-kernel - Re: [PATCH 11/15] regulator: core: Use fsleep() to get best sleep mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <544ffae4-b67b-4152-bebf-21a90c00fb76@sirena.org.uk>
Date: Wed, 4 Sep 2024 14:28:37 +0100
From: Mark Brown <broonie@...nel.org>
To: Anna-Maria Behnsen <anna-maria@...utronix.de>
Cc: Frederic Weisbecker <frederic@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Jonathan Corbet <corbet@....net>, linux-kernel@...r.kernel.org,
	Len Brown <len.brown@...el.com>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [PATCH 11/15] regulator: core: Use fsleep() to get best sleep
 mechanism

On Wed, Sep 04, 2024 at 03:05:01PM +0200, Anna-Maria Behnsen wrote:
> _regulator_delay_helper() implements the recommondation of the outdated
> documentation which sleep mechanism should be used. There is already a
> function in place which does everything and also maps to reality called
> fsleep().

> - * Delay for the requested amount of time as per the guidelines in:
> + * For details please refere to fsleep() function description.

> -static void _regulator_delay_helper(unsigned int delay)
> +static inline void _regulator_delay_helper(unsigned int delay)

Gien that this just becomes a trivial wrapper for fsleep() why not just
replace all the calls with fsleep() and remove the function entirely?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)