linux-kernel - Re: [PATCH] nvdimm: Use of_property_present() and of_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <66d865bec41f1_1e915829465@iweiny-mobl.notmuch>
Date: Wed, 4 Sep 2024 08:50:54 -0500
From: Ira Weiny <ira.weiny@...el.com>
To: Rob Herring <robh@...nel.org>, Dan Williams <dan.j.williams@...el.com>,
	Vishal Verma <vishal.l.verma@...el.com>, Dave Jiang <dave.jiang@...el.com>,
	Ira Weiny <ira.weiny@...el.com>, Oliver O'Halloran <oohall@...il.com>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
CC: <nvdimm@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nvdimm: Use of_property_present() and
 of_property_read_bool()

Rob Herring wrote:
> On Wed, Jul 31, 2024 at 2:14 PM Rob Herring (Arm) <robh@...nel.org> wrote:
> >
> > Use of_property_present() and of_property_read_bool() to test
> > property presence and read boolean properties rather than
> > of_(find|get)_property(). This is part of a larger effort to remove
> > callers of of_find_property() and similar functions.
> > of_(find|get)_property() leak the DT struct property and data pointers
> > which is a problem for dynamically allocated nodes which may be freed.
> >
> > Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> > ---
> >  drivers/nvdimm/of_pmem.c | 2 +-
> >  drivers/nvmem/layouts.c  | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> Ping

It is soaking for 6.12.

https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git/log/?h=libnvdimm-for-next

Thanks,
Ira

> 
> > diff --git a/drivers/nvdimm/of_pmem.c b/drivers/nvdimm/of_pmem.c
> > index 403384f25ce3..b4a1cf70e8b7 100644
> > --- a/drivers/nvdimm/of_pmem.c
> > +++ b/drivers/nvdimm/of_pmem.c
> > @@ -47,7 +47,7 @@ static int of_pmem_region_probe(struct platform_device *pdev)
> >         }
> >         platform_set_drvdata(pdev, priv);
> >
> > -       is_volatile = !!of_find_property(np, "volatile", NULL);
> > +       is_volatile = of_property_read_bool(np, "volatile");
> >         dev_dbg(&pdev->dev, "Registering %s regions from %pOF\n",
> >                         is_volatile ? "volatile" : "non-volatile",  np);
> >
> > diff --git a/drivers/nvmem/layouts.c b/drivers/nvmem/layouts.c
> > index 77a4119efea8..65d39e19f6ec 100644
> > --- a/drivers/nvmem/layouts.c
> > +++ b/drivers/nvmem/layouts.c
> > @@ -123,7 +123,7 @@ static int nvmem_layout_bus_populate(struct nvmem_device *nvmem,
> >         int ret;
> >
> >         /* Make sure it has a compatible property */
> > -       if (!of_get_property(layout_dn, "compatible", NULL)) {
> > +       if (!of_property_present(layout_dn, "compatible")) {
> >                 pr_debug("%s() - skipping %pOF, no compatible prop\n",
> >                          __func__, layout_dn);
> >                 return 0;
> > --
> > 2.43.0
> >