linux-kernel - Re: [PATCH] um: kunit: resolve missing prototypes warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <942a2aa5fc93f6dc1bc88b3b25e59b044a7a425f.camel@sipsolutions.net>
Date: Wed, 04 Sep 2024 15:56:42 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Gabriele Monaco <gmonaco@...hat.com>, Arnd Bergmann <arnd@...db.de>, 
	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Brendan Higgins <brendan.higgins@...ux.dev>, David Gow
 <davidgow@...gle.com>,  Rae Moar <rmoar@...gle.com>,
 linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com, Richard
 Weinberger <richard@....at>, Anton Ivanov
 <anton.ivanov@...bridgegreys.com>,  linux-um@...ts.infradead.org
Subject: Re: [PATCH] um: kunit: resolve missing prototypes warning

On Wed, 2024-09-04 at 15:50 +0200, Gabriele Monaco wrote:
> While building for KUnit with default settings, the build is generating
> the following compilation warnings.
> 
> ```
> $ make ARCH=um O=.kunit --jobs=16
> ../lib/iomap.c:156:5: warning: no previous prototype for
> ‘ioread64_lo_hi’ [-Wmissing-prototypes]
>   156 | u64 ioread64_lo_hi(const void __iomem *addr)
>       |     ^~~~~~~~~~~~~~
> [...]
> ```
> 
> The warning happens because the prototypes are defined in
> `asm-generic/iomap.h` only when `readq` and `writeq` are defined.
> For UM, those function get some default definitions but are currently
> defined _after_ the prototypes for `ioread64*`/`iowrite64*` functions.
> Moving the inclusion of `asm-generic/iomap.h` fixes it.
> 
> Signed-off-by: Gabriele Monaco <gmonaco@...hat.com>
> ---
>  include/asm-generic/io.h | 8 ++++----

I get that you have this on kunit on ARCH=um, but that makes it neither
a kunit nor a um patch :)

Arnd had originally wanted to fix this another way, but that got
dropped. I don't know if this fix is right, though I can see that it
works. I have the same workaround in my tree, but I'm really not
convinced that it doesn't have side-effects on other architectures.

johannes