[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c387b2df-4a49-434f-b660-765599f9ec0d@linumiz.com>
Date: Wed, 4 Sep 2024 19:51:38 +0530
From: karthikeyan <karthikeyan@...umiz.com>
To: Heiko Stübner <heiko@...ech.de>, robh@...nel.org,
krzk+dt@...nel.org, conor+dt@...nel.org, alexandre.belloni@...tlin.com
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-rtc@...r.kernel.org
Subject: Re: [PATCH v2 4/8] ARM: dts: rockchip: Add watchdog node for RV1126
On 9/4/24 14:41, Heiko Stübner wrote:
> Am Dienstag, 3. September 2024, 12:52:41 CEST schrieb Karthikeyan Krishnasamy:
>> Add watchdog node for Rockchip RV1126
>>
>> Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@...umiz.com>
>
> this needs a separate patch for adding a watchdog compatible to
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml#n33
>
> see for example
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=dcd615ee6fd3651ab0357364c4cf65b1148a40be
>
> Thanks
> Heiko
>
Additional patch for compatible string, Got it. I will added in the next
version. Thanks.
>> ---
>>
>> Notes:
>> v2:
>> - No change
>>
>> arch/arm/boot/dts/rockchip/rv1126.dtsi | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rockchip/rv1126.dtsi b/arch/arm/boot/dts/rockchip/rv1126.dtsi
>> index abf442804d27..283985608428 100644
>> --- a/arch/arm/boot/dts/rockchip/rv1126.dtsi
>> +++ b/arch/arm/boot/dts/rockchip/rv1126.dtsi
>> @@ -544,6 +544,14 @@ timer0: timer@...60000 {
>> clock-names = "pclk", "timer";
>> };
>>
>> + wdt: watchdog@...80000 {
>> + compatible = "snps,dw-wdt";
>> + reg = <0xff680000 0x100>;
>> + clocks = <&cru PCLK_WDT>;
>> + interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
>> + status = "disabled";
>> + };
>> +
>> i2s0: i2s@...00000 {
>> compatible = "rockchip,rv1126-i2s-tdm";
>> reg = <0xff800000 0x1000>;
>>
>
>
>
>
Best Regards,
Karthikeyan
Powered by blists - more mailing lists