linux-kernel - Re: [PATCH net v3] fsl/fman: Validate cell-index value obtained from Device Tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240904072307.1b17227c@kernel.org>
Date: Wed, 4 Sep 2024 07:23:07 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Aleksandr Mishin <amishin@...rgos.ru>
Cc: Igal Liberman <igal.liberman@...escale.com>, Madalin Bucur
 <madalin.bucur@....com>, Sean Anderson <sean.anderson@...o.com>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, <netdev@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <lvc-project@...uxtesting.org>
Subject: Re: [PATCH net v3] fsl/fman: Validate cell-index value obtained
 from Device Tree

On Wed, 4 Sep 2024 09:09:20 +0300 Aleksandr Mishin wrote:
> Cell-index value is obtained from Device Tree and then used to calculate
> the index for accessing arrays port_mfl[], mac_mfl[] and intr_mng[].
> In case of broken DT due to any error cell-index can contain any value
> and it is possible to go beyond the array boundaries which can lead
> at least to memory corruption.
> 
> Validate cell-index value obtained from Device Tree.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.

coccicheck complains of_dev is not released, we should fix that first,
before we add more returns here.
-- 
pw-bot: cr