linux-kernel - Re: [PATCH 1/1] dt-bindings: mmc: Add support for rk3576 eMMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <26d8ecbe-0d85-4be2-a142-861088e43918@kernel.org>
Date: Wed, 4 Sep 2024 16:25:54 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Detlev Casanova <detlev.casanova@...labora.com>,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: linux-kernel@...r.kernel.org, Ulf Hansson <ulf.hansson@...aro.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Jisheng Zhang <jszhang@...nel.org>,
 linux-mmc@...r.kernel.org, devicetree@...r.kernel.org, kernel@...labora.com
Subject: Re: [PATCH 1/1] dt-bindings: mmc: Add support for rk3576 eMMC

On 04/09/2024 16:20, Detlev Casanova wrote:
>>>>> +      properties:
>>>>> +        power-domains:
>>>>> +          minItems: 1
>>>>
>>>> Why minItems? This does not look right. I don't get what you are trying
>>>> to say here.
>>>
>>> I'm saying that for the rockchip,rk3576-dwcmshc compatible, 1 power-domain
>>> node has to be set.
>>
>> The top-level property already says this. You need to disallow it for
>> other variants (:false).
> 
> Ok, something like this:
> 
> allOf:
>   - if:
>       properties:
>         compatible:
>           contains:
>             const: rockchip,rk3576-dwcmshc
> 
>     then:
>       required:
>         - power-domains
> 
>     else:
>       properties:
>         power-domains: false

Yes, if they are required. Otherwise use "if: not:" and just disallow them.

Best regards,
Krzysztof