linux-kernel - Re: [PATCH] wifi: brcmfmac: cfg80211: Convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4c1c9d54-3abc-41be-8d29-7cfc1680dc87@broadcom.com>
Date: Wed, 4 Sep 2024 16:43:17 +0200
From: Arend van Spriel <arend.vanspriel@...adcom.com>
To: Chen Ni <nichen@...as.ac.cn>, kvalo@...nel.org, johannes.berg@...el.com,
 kees@...nel.org, a@...repo.ru, wsa+renesas@...g-engineering.com,
 quic_alokad@...cinc.com, marcan@...can.st, j@...nau.net
Cc: linux-wireless@...r.kernel.org, brcm80211@...ts.linux.dev,
 brcm80211-dev-list.pdl@...adcom.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wifi: brcmfmac: cfg80211: Convert comma to semicolon

On 9/4/2024 9:46 AM, Chen Ni wrote:
> Replace comma between expressions with semicolons.
> 
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.

Almost certainly not intended or at least I can not think of a reason 
for that construct here so without further ado ....
> Found by inspection.
> No functional change intended.
> Compile tested only.

Acked-by: Arend van Spriel <arend.vanspriel@...adcom.com>
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
>   drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)