linux-kernel - Re: [PATCH v2 1/2] crypto: qcom-rng: fix support for ACPI-based systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABx5tqLh_8OMSrZsCFz3wpw4dQf6pQtQ_Ffh35Abop2fqhobTg@mail.gmail.com>
Date: Wed, 4 Sep 2024 10:43:34 -0400
From: Brian Masney <bmasney@...hat.com>
To: herbert@...dor.apana.org.au
Cc: davem@...emloft.net, quic_omprsing@...cinc.com, neil.armstrong@...aro.org, 
	quic_bjorande@...cinc.com, linux-arm-msm@...r.kernel.org, 
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org, 
	ernesto.mnd.fernandez@...il.com, quic_jhugo@...cinc.com
Subject: Re: [PATCH v2 1/2] crypto: qcom-rng: fix support for ACPI-based systems

On Tue, Sep 3, 2024 at 5:22 PM Brian Masney <bmasney@...hat.com> wrote:
> The qcom-rng driver supports both ACPI and device tree based systems.
> ACPI support was broken when the hw_random interface support was added.
> Let's go ahead and fix this by adding a check for has_acpi_companion().
>
> This fix was boot tested on a Qualcomm Amberwing server.
>
> Fixes: f29cd5bb64c2 ("crypto: qcom-rng - Add hw_random interface support")
> Reported-by: Ernesto A. Fernández <ernesto.mnd.fernandez@...il.com>
> Closes: https://lore.kernel.org/linux-arm-msm/20240828184019.GA21181@eaf/
> Cc: stable@...r.kernel.org
> Signed-off-by: Brian Masney <bmasney@...hat.com>

I found a cleaner and less intrusive way to fix this after looking
through some other drivers, so let me post a v3. Sorry about the
noise.

Brian