linux-kernel - Re: [PATCH next] iommu/tegra241-cmdqv: Fix ioremap() error handling in probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zthzx06kZv+FyXJT@Asurada-Nvidia>
Date: Wed, 4 Sep 2024 07:50:47 -0700
From: Nicolin Chen <nicolinc@...dia.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: Nate Watterson <nwatterson@...dia.com>, Thierry Reding
	<thierry.reding@...il.com>, Krishna Reddy <vdumpa@...dia.com>, Will Deacon
	<will@...nel.org>, Robin Murphy <robin.murphy@....com>, Joerg Roedel
	<joro@...tes.org>, Jonathan Hunter <jonathanh@...dia.com>, Jason Gunthorpe
	<jgg@...pe.ca>, <linux-tegra@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <iommu@...ts.linux.dev>,
	<linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH next] iommu/tegra241-cmdqv: Fix ioremap() error handling
 in probe()

On Wed, Sep 04, 2024 at 11:02:43AM +0300, Dan Carpenter wrote:
> The ioremap() function doesn't return error pointers, it returns NULL
> on error so update the error handling.  Also just return directly
> instead of calling iounmap() on the NULL pointer.  Calling
> iounmap(NULL) doesn't cause a problem on ARM but on other architectures
> it can trigger a warning so it'a bad habbit.
> 
> Fixes: 918eb5c856f6 ("iommu/arm-smmu-v3: Add in-kernel support for NVIDIA Tegra241 (Grace) CMDQV")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Nicolin Chen <nicolinc@...dia.com>

Thanks!