[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAGb2v65qZweU+iB+3BBkkcHhQ-aPWUCcPLWqvPdXHCOtOXhqfA@mail.gmail.com>
Date: Wed, 4 Sep 2024 22:52:47 +0800
From: Chen-Yu Tsai <wens@...e.org>
To: Kryštof Černý <cleverline1mc@...il.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Jernej Skrabec <jernej.skrabec@...il.com>,
Samuel Holland <samuel@...lland.org>, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/3] Fix regulators and assign them on NanoPi NEO Plus2
Hi,
On Wed, Aug 28, 2024 at 5:01 AM Kryštof Černý <cleverline1mc@...il.com> wrote:
>
> Many thanks for your feedback, especially from André Przywara,
> I learned a lot from you and your kind words motivated me to do a follow-up.
> Regulators should correspond to reality (schematics).
> Proper regulators were added for pio and r_pio.
> Added missing regulator for mmc2.
>
> Signed-off-by: Kryštof Černý <cleverline1mc@...il.com>
> ---
> Kryštof Černý (3):
> Fix NanoPi NEO Plus2 regulators
> Use regulators for pio on NanoPi NEO Plus2
> Add vqmmc-supply on NanoPi NEO Plus2
I just realized that all your patch subjects are missing the proper prefixes.
Can you check the history of the file you changed to see what is usually
used and send a revised version?
Thanks
ChenYu
>
> .../dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts | 38 ++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
> ---
> base-commit: 6f923748057a4f6aa187e0d5b22990d633a48d12
> change-id: 20240827-nanopi-neo-plus2-regfix-b60116ce12ca
>
> Best regards,
> --
> Kryštof Černý <cleverline1mc@...il.com>
>
Powered by blists - more mailing lists