linux-kernel - Re: [PATCH v5 0/2] arm64: Implement getrandom() in vDSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240904150254.GA13919@willie-the-truck>
Date: Wed, 4 Sep 2024 16:02:55 +0100
From: Will Deacon <will@...nel.org>
To: "Jason A. Donenfeld" <Jason@...c4.com>
Cc: Ard Biesheuvel <ardb@...nel.org>,
	Adhemerval Zanella <adhemerval.zanella@...aro.org>,
	Theodore Ts'o <tytso@....edu>, linux-kernel@...r.kernel.org,
	linux-crypto@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-arch@...r.kernel.org,
	Catalin Marinas <catalin.marinas@....com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Eric Biggers <ebiggers@...nel.org>,
	Christophe Leroy <christophe.leroy@...roup.eu>
Subject: Re: [PATCH v5 0/2] arm64: Implement getrandom() in vDSO

On Wed, Sep 04, 2024 at 03:53:42PM +0200, Jason A. Donenfeld wrote:
> On Wed, Sep 04, 2024 at 02:28:32PM +0200, Ard Biesheuvel wrote:
> > On Wed, 4 Sept 2024 at 14:05, Will Deacon <will@...nel.org> wrote:
> > >
> > > +Ard as he had helpful comments on the previous version.
> > >
> > 
> > Thanks for the cc
> > 
> > > On Tue, Sep 03, 2024 at 12:09:15PM +0000, Adhemerval Zanella wrote:
> > > > Implement stack-less ChaCha20 and wire it with the generic vDSO
> > > > getrandom code.  The first patch is Mark's fix to the alternatives
> > > > system in the vDSO, while the the second is the actual vDSO work.
> > > >
> > > > Changes from v4:
> > > > - Improve BE handling.
> > > >
> > > > Changes from v3:
> > > > - Use alternative_has_cap_likely instead of ALTERNATIVE.
> > > > - Header/include and comment fixups.
> > > >
> > > > Changes from v2:
> > > > - Refactor Makefile to use same flags for vgettimeofday and
> > > >   vgetrandom.
> > > > - Removed rodata usage and fixed BE on vgetrandom-chacha.S.
> > > >
> > > > Changes from v1:
> > > > - Fixed style issues and typos.
> > > > - Added fallback for systems without NEON support.
> > > > - Avoid use of non-volatile vector registers in neon chacha20.
> > > > - Use c-getrandom-y for vgetrandom.c.
> > > > - Fixed TIMENS vdso_rnd_data access.
> > > >
> > > > Adhemerval Zanella (1):
> > > >   arm64: vdso: wire up getrandom() vDSO implementation
> > > >
> > > > Mark Rutland (1):
> > > >   arm64: alternative: make alternative_has_cap_likely() VDSO compatible
> > > >
> > 
> > This looks ok to me now
> > 
> > Reviewed-by: Ard Biesheuvel <ardb@...nel.org>
> 
> Great. Thanks a bunch for your reviews, Ard.
> 
> Will, if you want to Ack this, I'll queue it up with the other getrandom
> vDSO patches for 6.12.

I won't pretend to have reviewed the chacha asm, but the rest of it looks
good to me. Thanks!

Acked-by: Will Deacon <will@...nel.org>

Will