[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240904151115.205622-1-carlos.bilbao.osdev@gmail.com>
Date: Wed, 4 Sep 2024 10:11:13 -0500
From: Carlos Bilbao <carlos.bilbao.osdev@...il.com>
To: dtatulea@...dia.com,
mst@...hat.com,
jasowang@...hat.com,
shannon.nelson@....com,
sashal@...nel.org,
alvaro.karsz@...id-run.com,
christophe.jaillet@...adoo.fr,
steven.sistare@...cle.com
Cc: bilbao@...edu,
xuanzhuo@...ux.alibaba.com,
johnah.palmer@...cle.com,
eperezma@...hat.com,
cratiu@...dia.com,
virtualization@...ts.linux.dev,
linux-kernel@...r.kernel.org,
Carlos Bilbao <cbilbao@...italocean.com>
Subject: [PATCH v3 0/2] Properly initialize speed/duplex and remove vDPA config updates
From: Carlos Bilbao <cbilbao@...italocean.com>
Initialize speed and duplex for virtio_net_config to UNKNOWN (mlx5_vdpa
vDPA devices currently do not support VIRTIO_NET_F_SPEED_DUPLEX). Remove
ioctl VHOST_VDPA_SET_CONFIG and its related logic as it is not supported;
see: https://docs.oasis-open.org/virtio/virtio/v1.3/virtio-v1.3.html
Carlos:
vdpa/mlx5: Set speed and duplex of vDPA devices to UNKNOWN
vdpa: Remove ioctl VHOST_VDPA_SET_CONFIG per spec compliance
---
Changes since v1:
Link: https://lkml.org/lkml/2024/8/29/1368
- Fix prefix of the first commit and add Reviewed-By tag.
- Redo second commit completely: instead of attempting to add support to
set configuration fields, remove ioctl and support entirely from vDPA
implementations -- because it's not allowed by spec.
Changes since v2:
Link: https://lkml.org/lkml/2024/9/3/1407
- Fix first commit by changing 4 spaces for a tab.
- In second commit, ENI is legacy and should keep set_config(). Change it
to set_config_legacy() to avoid future confusion and erroneous
implementations.
---
drivers/vdpa/alibaba/eni_vdpa.c | 2 +-
drivers/vdpa/ifcvf/ifcvf_main.c | 10 ----------
drivers/vdpa/mlx5/net/mlx5_vnet.c | 19 ++++++++++++-------
drivers/vdpa/pds/vdpa_dev.c | 16 ----------------
drivers/vdpa/solidrun/snet_main.c | 18 ------------------
drivers/vdpa/vdpa.c | 16 ----------------
drivers/vdpa/vdpa_sim/vdpa_sim.c | 16 ----------------
drivers/vdpa/vdpa_sim/vdpa_sim.h | 1 -
drivers/vdpa/vdpa_user/vduse_dev.c | 7 -------
drivers/vdpa/virtio_pci/vp_vdpa.c | 14 --------------
drivers/vhost/vdpa.c | 26 --------------------------
drivers/virtio/virtio_vdpa.c | 9 ---------
include/linux/vdpa.h | 7 ++++---
include/uapi/linux/vhost.h | 8 ++++----
14 files changed, 21 insertions(+), 148 deletions(-)
Powered by blists - more mailing lists