linux-kernel - Re: [PATCH net-next v2 3/3] net: smc91x: Make use of irq_get_trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <xjsyqdymlfr4za57qj4ju4gsuuulavpjheuauymynepzqld4nw@xeqt4ofptkp5>
Date: Wed, 4 Sep 2024 15:41:11 +0000
From: Alvin Šipraga <ALSI@...g-olufsen.dk>
To: Vasileios Amoiridis <vassilisamir@...il.com>
CC: "linus.walleij@...aro.org" <linus.walleij@...aro.org>, "andrew@...n.ch"
	<andrew@...n.ch>, "f.fainelli@...il.com" <f.fainelli@...il.com>,
	"olteanv@...il.com" <olteanv@...il.com>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"nico@...xnic.net" <nico@...xnic.net>, "leitao@...ian.org"
	<leitao@...ian.org>, "u.kleine-koenig@...gutronix.de"
	<u.kleine-koenig@...gutronix.de>, "thorsten.blum@...lux.com"
	<thorsten.blum@...lux.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2 3/3] net: smc91x: Make use of
 irq_get_trigger_type()

On Wed, Sep 04, 2024 at 05:10:18PM GMT, Vasileios Amoiridis wrote:
> Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
> simple irq_get_trigger_type(irq).
> 
> Signed-off-by: Vasileios Amoiridis <vassilisamir@...il.com>
> ---
>  drivers/net/ethernet/smsc/smc91x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Alvin Šipraga <alsi@...g-olufsen.dk>

> 
> diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c
> index 907498848028..a5e23e2da90f 100644
> --- a/drivers/net/ethernet/smsc/smc91x.c
> +++ b/drivers/net/ethernet/smsc/smc91x.c
> @@ -2355,7 +2355,7 @@ static int smc_drv_probe(struct platform_device *pdev)
>  	 * the resource supplies a trigger, override the irqflags with
>  	 * the trigger flags from the resource.
>  	 */
> -	irq_resflags = irqd_get_trigger_type(irq_get_irq_data(ndev->irq));
> +	irq_resflags = irq_get_trigger_type(ndev->irq);
>  	if (irq_flags == -1 || irq_resflags & IRQF_TRIGGER_MASK)
>  		irq_flags = irq_resflags & IRQF_TRIGGER_MASK;
>  
> -- 
> 2.25.1
>