linux-kernel - Re: [PATCH net-next v17 05/14] xtensa: remove the get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKgT0UfCoaSE-tkB0TnSucOr8AmB69838-UHpwTOFxH+GVTQnA@mail.gmail.com>
Date: Wed, 4 Sep 2024 08:48:25 -0700
From: Alexander Duyck <alexander.duyck@...il.com>
To: Yunsheng Lin <linyunsheng@...wei.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Max Filippov <jcmvbkbc@...il.com>, Chris Zankel <chris@...kel.net>
Subject: Re: [PATCH net-next v17 05/14] xtensa: remove the get_order() implementation

On Mon, Sep 2, 2024 at 5:09 AM Yunsheng Lin <linyunsheng@...wei.com> wrote:
>
> As the get_order() implemented by xtensa supporting 'nsau'
> instruction seems be the same as the generic implementation
> in include/asm-generic/getorder.h when size is not a constant
> value as the generic implementation calling the fls*() is also
> utilizing the 'nsau' instruction for xtensa.
>
> So remove the get_order() implemented by xtensa, as using the
> generic implementation may enable the compiler to do the
> computing when size is a constant value instead of runtime
> computing and enable the using of get_order() in BUILD_BUG_ON()
> macro in next patch.
>
> CC: Alexander Duyck <alexander.duyck@...il.com>
> Signed-off-by: Yunsheng Lin <linyunsheng@...wei.com>
> Acked-by: Max Filippov <jcmvbkbc@...il.com>
> ---
>  arch/xtensa/include/asm/page.h | 18 ------------------
>  1 file changed, 18 deletions(-)
>

Reviewed-by: Alexander Duyck <alexanderduyck@...com>