linux-kernel - Re: [PATCH net-next] ionic: Convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bea7d62c-5a2e-4eb1-add4-212f7ea25608@amd.com>
Date: Wed, 4 Sep 2024 08:51:28 -0700
From: "Nelson, Shannon" <shannon.nelson@....com>
To: Chen Ni <nichen@...as.ac.cn>, brett.creeley@....com, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] ionic: Convert comma to semicolon

On 9/4/2024 1:17 AM, Chen Ni wrote:
> 
> Replace comma between expressions with semicolons.
> 
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
> 
> Found by inspection.
> No functional change intended.
> Compile tested only.
> 
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
>   drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c b/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c
> index 1ee2f285cb42..528114877677 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c
> @@ -312,8 +312,8 @@ static int ionic_lif_filter_add(struct ionic_lif *lif,
>          int err = 0;
> 
>          ctx.cmd.rx_filter_add = *ac;
> -       ctx.cmd.rx_filter_add.opcode = IONIC_CMD_RX_FILTER_ADD,
> -       ctx.cmd.rx_filter_add.lif_index = cpu_to_le16(lif->index),
> +       ctx.cmd.rx_filter_add.opcode = IONIC_CMD_RX_FILTER_ADD;
> +       ctx.cmd.rx_filter_add.lif_index = cpu_to_le16(lif->index);
> 
>          spin_lock_bh(&lif->rx_filters.lock);
>          f = ionic_rx_filter_find(lif, &ctx.cmd.rx_filter_add);
> --
> 2.25.1
> 


Thanks for catching that.

Reviewed-by: Shannon Nelson <shannon.nelson@....com>