[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20240904160028.cjmnadqgcwynncmh@skbuf>
Date: Wed, 4 Sep 2024 19:00:28 +0300
From: Vladimir Oltean <olteanv@...il.com>
To: Furong Xu <0x1207@...il.com>
Cc: Alexander Lobakin <aleksander.lobakin@...el.com>,
Serge Semin <fancer.lancer@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Jose Abreu <joabreu@...opsys.com>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Joao Pinto <jpinto@...opsys.com>, netdev@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
rmk+kernel@...linux.org.uk, linux@...linux.org.uk, xfr@...look.com
Subject: Re: [PATCH net-next v7 7/7] net: stmmac: silence FPE kernel logs
On Wed, Sep 04, 2024 at 05:21:22PM +0800, Furong Xu wrote:
> ethtool --show-mm can get real-time state of FPE.
> Those kernel logs should keep quiet.
>
> Signed-off-by: Furong Xu <0x1207@...il.com>
> ---
I don't have a stmmac-based setup to judge in person. But to me, these
still look too chatty, for being things that user space can always query
through netlink.
1070 » netdev_info(priv->dev, "configured EST\n");
1090 » netdev_info(priv->dev, "disabled FPE\n");
Also, they don't seem to be balanced. We don't have "disabled EST" and
"enabled FPE"?! I wonder if "disabled FPE" is actually a typo and should
have been "disabled EST"?
What do you think, should these also be suppressed / deleted?
Powered by blists - more mailing lists