linux-kernel - Re: [RFC 21/31] objtool: Fix x86 addend calcuation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240904161549.y3gif5bnyj7reysa@treble>
Date: Wed, 4 Sep 2024 09:15:49 -0700
From: Josh Poimboeuf <jpoimboe@...nel.org>
To: laokz <laokz@...mail.com>
Cc: live-patching@...r.kernel.org, linux-kernel@...r.kernel.org,
	x86@...nel.org, Miroslav Benes <mbenes@...e.cz>,
	Petr Mladek <pmladek@...e.com>,
	Joe Lawrence <joe.lawrence@...hat.com>,
	Jiri Kosina <jikos@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Marcos Paulo de Souza <mpdesouza@...e.com>,
	Song Liu <song@...nel.org>
Subject: Re: [RFC 21/31] objtool: Fix x86 addend calcuation

On Wed, Sep 04, 2024 at 05:24:21PM +0800, laokz wrote:
> On Mon, 2024-09-02 at 21:00 -0700, Josh Poimboeuf wrote:
> > +++ b/tools/objtool/arch/loongarch/decode.c
> > @@ -20,9 +20,9 @@ unsigned long arch_jump_destination(struct
> > instruction *insn)
> >         return insn->offset + (insn->immediate << 2);
> >  }
> >  
> > -unsigned long arch_dest_reloc_offset(int addend)
> > +s64 arch_insn_adjusted_addend(struct instruction *insn, struct reloc
> > *reloc)
> >  {
> > -       return addend;
> > +       return reloc_addend(addend);
> 
> reloc_addend(reloc) ?

Oops!

As you can probably tell, I haven't tested (or compiled) anything other
than x86 yet.

-- 
Josh