linux-kernel - Re: [PATCH] selftests: vDSO: don't include generated headers for chacha test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f12f377-0fd7-4178-b940-7917094ff2cb@linaro.org>
Date: Wed, 4 Sep 2024 13:19:29 -0300
From: Adhemerval Zanella Netto <adhemerval.zanella@...aro.org>
To: "Jason A. Donenfeld" <Jason@...c4.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests: vDSO: don't include generated headers for
 chacha test



On 04/09/24 12:58, Jason A. Donenfeld wrote:
> It's not correct to use $(top_srcdir) for generated header files, for
> builds that are done out of tree via O=, and $(objtree) isn't valid in
> the selftests context. Instead, just obviate the need for these
> generated header files by defining empty stubs in tools/include/asm,
> which is the same thing that's done for rwlock.h.
> 
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>

Works for me, thanks.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@...aro.org>

> ---
>  tools/include/asm/asm-offsets.h       | 0
>  tools/include/asm/cpucap-defs.h       | 0
>  tools/include/asm/sysreg-defs.h       | 0
>  tools/testing/selftests/vDSO/Makefile | 1 -
>  4 files changed, 1 deletion(-)
>  create mode 100644 tools/include/asm/asm-offsets.h
>  create mode 100644 tools/include/asm/cpucap-defs.h
>  create mode 100644 tools/include/asm/sysreg-defs.h
> 
> diff --git a/tools/include/asm/asm-offsets.h b/tools/include/asm/asm-offsets.h
> new file mode 100644
> index 000000000000..e69de29bb2d1
> diff --git a/tools/include/asm/cpucap-defs.h b/tools/include/asm/cpucap-defs.h
> new file mode 100644
> index 000000000000..e69de29bb2d1
> diff --git a/tools/include/asm/sysreg-defs.h b/tools/include/asm/sysreg-defs.h
> new file mode 100644
> index 000000000000..e69de29bb2d1
> diff --git a/tools/testing/selftests/vDSO/Makefile b/tools/testing/selftests/vDSO/Makefile
> index 3c6fafbd83a6..55038a65fa61 100644
> --- a/tools/testing/selftests/vDSO/Makefile
> +++ b/tools/testing/selftests/vDSO/Makefile
> @@ -40,6 +40,5 @@ $(OUTPUT)/vdso_test_getrandom: CFLAGS += -isystem $(top_srcdir)/tools/include \
>  $(OUTPUT)/vdso_test_chacha: $(top_srcdir)/tools/arch/$(SRCARCH)/vdso/vgetrandom-chacha.S
>  $(OUTPUT)/vdso_test_chacha: CFLAGS += -idirafter $(top_srcdir)/tools/include \
>                                        -idirafter $(top_srcdir)/arch/$(SRCARCH)/include \
> -                                      -idirafter $(top_srcdir)/arch/$(SRCARCH)/include/generated \
>                                        -idirafter $(top_srcdir)/include \
>                                        -D__ASSEMBLY__ -Wa,--noexecstack