[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20240904174426.48bcb483@donnerap.manchester.arm.com>
Date: Wed, 4 Sep 2024 17:44:26 +0100
From: Andre Przywara <andre.przywara@....com>
To: Kryštof Černý <cleverline1mc@...il.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>, Jernej
Skrabec <jernej.skrabec@...il.com>, Samuel Holland <samuel@...lland.org>,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] Fix NanoPi NEO Plus2 regulators
On Tue, 27 Aug 2024 23:00:43 +0200
Kryštof Černý <cleverline1mc@...il.com> wrote:
Hi,
> Added the main board 5 V supply regulator,
> a 2.5 V supply regulator for GMAC PHY IO and correct vin-supply elements.
thanks for sending this and fixing the DT!
That looks correct when comparing to the schematics:
> Signed-off-by: Kryštof Černý <cleverline1mc@...il.com>
Reviewed-by: Andre Przywara <andre.przywara@....com>
Cheers,
Andre
> ---
> .../dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts | 25 ++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
> index b69032c44557..dee4cd82636b 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
> @@ -45,16 +45,40 @@ reg_gmac_3v3: gmac-3v3 {
> startup-delay-us = <100000>;
> enable-active-high;
> gpio = <&pio 3 6 GPIO_ACTIVE_HIGH>;
> + vin-supply = <®_vcc3v3>;
> + };
> +
> + reg_gmac_2v5: gmac-2v5 {
> + /* 2V5 supply for GMAC PHY IO */
> + compatible = "regulator-fixed";
> + regulator-name = "gmac-2v5";
> + regulator-min-microvolt = <2500000>;
> + regulator-max-microvolt = <2500000>;
> + regulator-always-on;
> + vin-supply = <®_vcc3v3>;
> + };
> +
> + reg_vcc5v: regulator-vcc5v {
> + /* board 5V supply from micro USB or pin headers */
> + compatible = "regulator-fixed";
> + regulator-name = "vcc-5v";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + regulator-always-on;
> };
>
> reg_vcc3v3: vcc3v3 {
> + /* board 3V3 supply by SY8089A */
> compatible = "regulator-fixed";
> regulator-name = "vcc3v3";
> regulator-min-microvolt = <3300000>;
> regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + vin-supply = <®_vcc5v>;
> };
>
> vdd_cpux: gpio-regulator {
> + /* cpu voltage regulator MP2143DJ */
> compatible = "regulator-gpio";
> regulator-name = "vdd-cpux";
> regulator-type = "voltage";
> @@ -66,6 +90,7 @@ vdd_cpux: gpio-regulator {
> gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>;
> gpios-states = <0x1>;
> states = <1100000 0>, <1300000 1>;
> + vin-supply = <®_vcc5v>;
> };
>
> wifi_pwrseq: pwrseq {
>
Powered by blists - more mailing lists