linux-kernel - Re: [PATCH] arm64: stacktrace: fix the usage of ftrace_graph_ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240904125000.4261b234@gandalf.local.home>
Date: Wed, 4 Sep 2024 12:50:00 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Mark Rutland <mark.rutland@....com>
Cc: Will Deacon <will@...nel.org>, Puranjay Mohan <puranjay@...nel.org>,
 Catalin Marinas <catalin.marinas@....com>, "Madhavan T. Venkataraman"
 <madvenka@...ux.microsoft.com>, Kalesh Singh <kaleshsingh@...gle.com>,
 chenqiwu <qiwuchen55@...il.com>, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, puranjay12@...il.com
Subject: Re: [PATCH] arm64: stacktrace: fix the usage of
 ftrace_graph_ret_addr()

On Tue, 3 Sep 2024 16:07:51 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Thu, 29 Aug 2024 18:54:01 +0100
> Mark Rutland <mark.rutland@....com> wrote:
> 
> > Hi Steve,
> > 
> > On Mon, Jun 24, 2024 at 04:17:41PM -0400, Steven Rostedt wrote:  
> > > On Wed, 19 Jun 2024 13:43:18 +0100
> > > Will Deacon <will@...nel.org> wrote:
> > >     
> > > > > Catalin, Will, do you have any preference?      
> > > > 
> > > > I think it makes most sense if this patch travels together with
> > > > 29c1c24a2707 ("function_graph: Fix up ftrace_graph_ret_addr()"), so that
> > > > would be via Steve's tree. In which case:    
> > > 
> > > That makes sense to me. I'll go around pulling in all the updates to the
> > > arch code here (with the respective acks).    
> > 
> > Are you still planning to pick this up? On next-20240829 the ftrace
> > tests blow up (as below) due to having the core ftrace change to
> > ftrace_graph_ret_addr() but lacking the arm64 fix.
> > 
> > Splat on next-20240829:  
> 
> Ah, I didn't check to see if it was sent to linux-trace-kernel, so it
> wasn't in patchwork, hence I forgot :-p
> 
> I can add it this week.
> 

Actually, the code is in Linus's tree now, so it's probably better if it
goes through your tree.

Acked-by: Steven Rostedt (Google) <rostedt@...dmis.org>

-- Steve