linux-kernel - Re: [PATCH net-next v2] ptp: ptp_idt82p33: Convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240904165107.GC1722938@kernel.org>
Date: Wed, 4 Sep 2024 17:51:07 +0100
From: Simon Horman <horms@...nel.org>
To: Chen Ni <nichen@...as.ac.cn>
Cc: richardcochran@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] ptp: ptp_idt82p33: Convert comma to semicolon

On Wed, Sep 04, 2024 at 09:50:03AM +0800, Chen Ni wrote:
> Replace comma between expressions with semicolons.
> 
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
> 
> Found by inspection.
> No functional change intended.
> Compile tested only.
> 
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
> Changelog:
> 
> v1 -> v2:
> 
> 1. Update commit message.

Thanks for the update.

I checked and I was not able to see any other instances of this
problem in this file.

Reviewed-by: Simon Horman <horms@...nel.org>