linux-kernel - Re: [PATCH 2/6] spi: nxp-fspi: remove the imx8mp compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHCN7x+q_pV24Gy-pGb53r2G+J-=mWy7STM9cW125y10JDMYrQ@mail.gmail.com>
Date: Wed, 4 Sep 2024 12:47:24 -0500
From: Adam Ford <aford173@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: haibo.chen@....com, han.xu@....com, yogeshgaur.83@...il.com, 
	broonie@...nel.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de, 
	festevam@...il.com, singh.kuldeep87k@...il.com, hs@...x.de, 
	linux-spi@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, imx@...ts.linux.dev, 
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/6] spi: nxp-fspi: remove the imx8mp compatible string

On Wed, Sep 4, 2024 at 11:32 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On 04/09/2024 13:17, haibo.chen@....com wrote:
> > From: Haibo Chen <haibo.chen@....com>
> >
> > According to imx8mp RM, the fspi is compatible with the fspi on
> > imx8mm. So remove this redundant imx8mp compatible string here.

We'd need to have the device tree compatible fall back to
nxp,imx8mm-fspi, but it doesn't, so the driver would never associate
itself with nxp,imx8mp-fspi.

adam
> >
> > Fixes: 0467a97367d4 ("spi: fspi: enable fspi driver for on imx8mp")
> > Signed-off-by: Haibo Chen <haibo.chen@....com>
> > ---
>
>
> This breaks users.
>
> NAK
>
> Best regards,
> Krzysztof
>
>