linux-kernel - Re: [PATCH v1 0/4] Enable shared SE support over I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46653560-d8ea-4255-9df2-40a141d16fe3@quicinc.com>
Date: Wed, 4 Sep 2024 23:51:32 +0530
From: Mukesh Kumar Savaliya <quic_msavaliy@...cinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>, <konrad.dybcio@...aro.org>,
        <andersson@...nel.org>, <andi.shyti@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <dmaengine@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-i2c@...r.kernel.org>
CC: <quic_vdadhani@...cinc.com>
Subject: Re: [PATCH v1 0/4] Enable shared SE support over I2C



On 8/29/2024 3:26 PM, Bryan O'Donoghue wrote:
> On 29/08/2024 10:24, Mukesh Kumar Savaliya wrote:
>> This Series adds support to share QUP based I2C SE between subsystems.
>> Each subsystem should have its own GPII which interacts between SE and
>> GSI DMA HW engine.
> 
> What is SE ?
> 
> GPII - general purpose interrupt ... ?
> 
> You have too many acronyms here, which makes reading and understanding 
> your cover letter a bit hard.
> 
> Please define at least the term SE in your cover letter and in your patch.
> 
> In the patch you use the term TRE which without diving into the code I 
> vaguely remember is a register..
> 
> - GPII
> - GSI
> - SE
> - TRE
> 
> Need to be defined to make what's going on in this series more "grokable".
> 
> A cover letter should assume a reviewer is familiar with the basics of a 
> system - no need to define what I2C is but, similarly shouldn't assume a 
> reviewer is numerate in the taxonomy of vendor specific architecture 
> e.g. whats SE ?
> 
> ---
Sure,  Understood what to mention instead of short names. Let me have 
cover letter and upload next patch.
> bod