linux-kernel - [tip: irq/core] irqchip/apple-aic: Skip unnecessary enabling of use_fast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <172547569469.2215.8885468459533683081.tip-bot2@tip-bot2>
Date: Wed, 04 Sep 2024 18:48:14 -0000
From: "tip-bot2 for Nick Chan" <tip-bot2@...utronix.de>
To: linux-tip-commits@...r.kernel.org
Cc: Nick Chan <towinchenmi@...il.com>, Thomas Gleixner <tglx@...utronix.de>,
 Sven Peter <sven@...npeter.dev>, x86@...nel.org, linux-kernel@...r.kernel.org,
 maz@...nel.org
Subject:
 [tip: irq/core] irqchip/apple-aic: Skip unnecessary enabling of use_fast_ipi

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     5527b06c96715518bc58d1ebb29efc3653f66c5e
Gitweb:        https://git.kernel.org/tip/5527b06c96715518bc58d1ebb29efc3653f66c5e
Author:        Nick Chan <towinchenmi@...il.com>
AuthorDate:    Sun, 01 Sep 2024 11:40:05 +08:00
Committer:     Thomas Gleixner <tglx@...utronix.de>
CommitterDate: Wed, 04 Sep 2024 20:43:30 +02:00

irqchip/apple-aic: Skip unnecessary enabling of use_fast_ipi

use_fast_ipi is true by default and there is no need to "enable" it.

Signed-off-by: Nick Chan <towinchenmi@...il.com>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Reviewed-by: Sven Peter <sven@...npeter.dev>
Link: https://lore.kernel.org/all/20240901034143.12731-3-towinchenmi@gmail.com
---
 drivers/irqchip/irq-apple-aic.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
index 5c534d9..8d81d5f 100644
--- a/drivers/irqchip/irq-apple-aic.c
+++ b/drivers/irqchip/irq-apple-aic.c
@@ -987,9 +987,7 @@ static int __init aic_of_ic_init(struct device_node *node, struct device_node *p
 	off += sizeof(u32) * (irqc->max_irq >> 5); /* MASK_CLR */
 	off += sizeof(u32) * (irqc->max_irq >> 5); /* HW_STATE */
 
-	if (irqc->info.fast_ipi)
-		static_branch_enable(&use_fast_ipi);
-	else
+	if (!irqc->info.fast_ipi)
 		static_branch_disable(&use_fast_ipi);
 
 	irqc->info.die_stride = off - start_off;