linux-kernel - RE: [PATCH net-next v2] net: mana: Improve mana_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PH7PR21MB32600F26F4B287BDA8B493C7CA9C2@PH7PR21MB3260.namprd21.prod.outlook.com>
Date: Wed, 4 Sep 2024 19:33:11 +0000
From: Haiyang Zhang <haiyangz@...rosoft.com>
To: Shradha Gupta <shradhagupta@...ux.microsoft.com>,
	"linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>
CC: KY Srinivasan <kys@...rosoft.com>, Wei Liu <wei.liu@...nel.org>, Dexuan
 Cui <decui@...rosoft.com>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Long Li <longli@...rosoft.com>, Simon Horman
	<horms@...nel.org>, Konstantin Taranov <kotaranov@...rosoft.com>, Souradeep
 Chakrabarti <schakrabarti@...ux.microsoft.com>, Erick Archer
	<erick.archer@...look.com>, Pavan Chebbi <pavan.chebbi@...adcom.com>, Ahmed
 Zaki <ahmed.zaki@...el.com>, Colin Ian King <colin.i.king@...il.com>, Shradha
 Gupta <shradhagupta@...rosoft.com>
Subject: RE: [PATCH net-next v2] net: mana: Improve mana_set_channels() in low
 mem conditions



> -----Original Message-----
> From: Shradha Gupta <shradhagupta@...ux.microsoft.com>
> Sent: Sunday, September 1, 2024 11:46 PM
> To: linux-hyperv@...r.kernel.org; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; linux-rdma@...r.kernel.org
> Cc: Shradha Gupta <shradhagupta@...ux.microsoft.com>; KY Srinivasan
> <kys@...rosoft.com>; Haiyang Zhang <haiyangz@...rosoft.com>; Wei Liu
> <wei.liu@...nel.org>; Dexuan Cui <decui@...rosoft.com>; David S. Miller
> <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski
> <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; Long Li
> <longli@...rosoft.com>; Simon Horman <horms@...nel.org>; Konstantin
> Taranov <kotaranov@...rosoft.com>; Souradeep Chakrabarti
> <schakrabarti@...ux.microsoft.com>; Erick Archer
> <erick.archer@...look.com>; Pavan Chebbi <pavan.chebbi@...adcom.com>;
> Ahmed Zaki <ahmed.zaki@...el.com>; Colin Ian King
> <colin.i.king@...il.com>; Shradha Gupta <shradhagupta@...rosoft.com>
> Subject: [PATCH net-next v2] net: mana: Improve mana_set_channels() in
> low mem conditions
> 
> The mana_set_channels() function requires detaching the mana
> driver and reattaching it with changed channel values.
> During this operation if the system is low on memory, the reattach
> might fail, causing the network device being down.
> To avoid this we pre-allocate buffers at the beginning of set operation,
> to prevent complete network loss
> 
> Signed-off-by: Shradha Gupta <shradhagupta@...ux.microsoft.com>

Thanks.
Reviewed-by: Haiyang Zhang <haiyangz@...rosoft.com>