[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <d91e6446-bdb1-4c22-a5c3-4c3f3dccebdb@kernel.org>
Date: Wed, 4 Sep 2024 22:41:15 +0200
From: Matthieu Baerts <matttbe@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: mptcp@...ts.linux.dev, Mat Martineau <martineau@...nel.org>,
Geliang Tang <geliang@...nel.org>, "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
Shuah Khan <shuah@...nel.org>, netdev@...r.kernel.org,
linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 0/3] selftests: mptcp: add time per subtests in
TAP output
Hi Jakub,
Thank you for your reply!
On 04/09/2024 21:40, Jakub Kicinski wrote:
> On Wed, 4 Sep 2024 18:15:09 +0200 Matthieu Baerts wrote:
>>> Best I could come up with is:
>>>
>>> diff --git a/contest/remote/vmksft-p.py b/contest/remote/vmksft-p.py
>>> index fe9e87abdb5c..a37245bd5b30 100755
>>> --- a/contest/remote/vmksft-p.py
>>> +++ b/contest/remote/vmksft-p.py
>>> @@ -73,7 +73,7 @@ group3 testV skip
>>> tests = []
>>> nested_tests = False
>>>
>>> - result_re = re.compile(r"(not )?ok (\d+)( -)? ([^#]*[^ ])( # )?([^ ].*)?$")
>>> + result_re = re.compile(r"(not )?ok (\d+)( -)? ([^#]*[^ ])( +# )?([^ ].*)?$")
>>
>> Looks good to me. While at it, we can add a '+' for the spaces after the
>> '#':
>>
>> ( +# +)
>
> 👍️
>
>> I see you didn't commit the previous modification. I can open a PR if it
>> helps.
>
> I was just playing with the regexps in the interpreter. If you could
> send a PR that'd perfect.
Sure, done:
https://github.com/linux-netdev/nipa/pull/38
>>> time_re = re.compile(r"time=(\d+)ms")
>>>
>>> for line in full_run.split('\n'):
>>>
>>> Thoughts?
>>
>> In my v2, I will also strip these trailing whitespaces in the selftests,
>> they don't need to be there.
>
> Up to you - it doesn't violate the KTAP format and the visual alignment
> is nice. But it may trip up more regexps..
Yes, better be safe... I will keep the visual alignment for the non-TAP
output.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
Powered by blists - more mailing lists