linux-kernel - Re: [RFC 00/31] objtool, livepatch: Livepatch module generation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240904205949.2dfmw6f7tcnza3rw@treble>
Date: Wed, 4 Sep 2024 13:59:49 -0700
From: Josh Poimboeuf <jpoimboe@...nel.org>
To: Song Liu <song@...nel.org>
Cc: live-patching@...r.kernel.org, linux-kernel@...r.kernel.org,
	x86@...nel.org, Miroslav Benes <mbenes@...e.cz>,
	Petr Mladek <pmladek@...e.com>,
	Joe Lawrence <joe.lawrence@...hat.com>,
	Jiri Kosina <jikos@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Marcos Paulo de Souza <mpdesouza@...e.com>
Subject: Re: [RFC 00/31] objtool, livepatch: Livepatch module generation

On Wed, Sep 04, 2024 at 01:23:55PM -0700, Song Liu wrote:
> Hi Josh,
> 
> Thanks for the fix! The gcc kernel now compiles.
> 
> I am now testing with the attached config file (where I disabled
> CONFIG_DEBUG_INFO_BTF), with the attached patch.

Probably a good idea to disable BTF as I think it's causing some
confusion.

> The build was successful:
> 
> $ ./scripts/livepatch/klp-build 0001-test-klp.patch
> - klp-build: building original kernel
> - klp-build: building patched kernel
> - klp-build: diffing objects
> vmlinux.o: changed: bpf_map_mmap
> - klp-build: building patch module
> - klp-build: success
> 
> But I am not able to load it:
> # kpatch load livepatch.ko
> loading patch module: livepatch.ko
> insmod: ERROR: could not insert module livepatch.ko: Invalid parameters
> kpatch: failed to load module livepatch.ko
> # dmesg
> ...
> [ 7285.260195] livepatch: nothing to patch!
> ...

Weird, I'll try to recreate with your config (without BTF for now).

-- 
Josh