linux-kernel - RE: [EXTERNAL] Re: [net-next PATCH 1/4] octeontx2-pf: Defines common API for HW resources configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <CH0PR18MB43396EE468C12EB47B9E4CC9CD9C2@CH0PR18MB4339.namprd18.prod.outlook.com>
Date: Wed, 4 Sep 2024 05:48:08 +0000
From: Geethasowjanya Akula <gakula@...vell.com>
To: Pavan Chebbi <pavan.chebbi@...adcom.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net"
	<davem@...emloft.net>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "jiri@...nulli.us" <jiri@...nulli.us>,
        "edumazet@...gle.com"
	<edumazet@...gle.com>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Hariprasad Kelam
	<hkelam@...vell.com>
Subject: RE: [EXTERNAL] Re: [net-next PATCH 1/4] octeontx2-pf: Defines common
 API for HW resources configuration



>-----Original Message-----
>From: Pavan Chebbi <pavan.chebbi@...adcom.com>
>Sent: Tuesday, September 3, 2024 8:27 PM
>To: Geethasowjanya Akula <gakula@...vell.com>
>Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; kuba@...nel.org;
>davem@...emloft.net; pabeni@...hat.com; jiri@...nulli.us;
>edumazet@...gle.com; Sunil Kovvuri Goutham <sgoutham@...vell.com>;
>Subbaraya Sundeep Bhatta <sbhatta@...vell.com>; Hariprasad Kelam
><hkelam@...vell.com>
>Subject: [EXTERNAL] Re: [net-next PATCH 1/4] octeontx2-pf: Defines common
>API for HW resources configuration
>
>On Tue, Sep 3, 2024 at 6:11 PM Geetha sowjanya <gakula@...vell.com>
>wrote:
>>
>> -
>>         /* Assign default mac address */
>>         otx2_get_mac_from_af(netdev);
>>
>> @@ -3118,11 +3141,8 @@ static int otx2_probe(struct pci_dev *pdev, const
>struct pci_device_id *id)
>>         if (test_bit(CN10K_LMTST, &pf->hw.cap_flag))
>>                 qmem_free(pf->dev, pf->dync_lmt);
>>         otx2_detach_resources(&pf->mbox);
>Isn't some of this unwinding/cleanup already moved to the new
>function? Looks like duplicate code to me.
No. If the otx2_probe () fails in any of the function after " otx2_init_rsrc()" function call.
Then below code cleanup the resources allocated.
>
>> -err_disable_mbox_intr:
>>         otx2_disable_mbox_intr(pf);
>> -err_mbox_destroy:
>>         otx2_pfaf_mbox_destroy(pf);
>> -err_free_irq_vectors:
>>         pci_free_irq_vectors(hw->pdev);
>>  err_free_netdev:
>>         pci_set_drvdata(pdev, NULL);
>> --
>> 2.25.1
>>
>>