linux-kernel - Re: [PATCH v2 2/2] vdpa: Remove ioctl VHOST_VDPA_SET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <faafc28a-23a9-4dff-8223-1c72acb42443@nvidia.com>
Date: Wed, 4 Sep 2024 07:58:56 +0200
From: Dragos Tatulea <dtatulea@...dia.com>
To: Jason Wang <jasowang@...hat.com>,
 Carlos Bilbao <carlos.bilbao.osdev@...il.com>
Cc: mst@...hat.com, shannon.nelson@....com, sashal@...nel.org,
 alvaro.karsz@...id-run.com, christophe.jaillet@...adoo.fr,
 steven.sistare@...cle.com, bilbao@...edu, xuanzhuo@...ux.alibaba.com,
 johnah.palmer@...cle.com, eperezma@...hat.com, cratiu@...dia.com,
 virtualization@...ts.linux.dev, linux-kernel@...r.kernel.org,
 Carlos Bilbao <cbilbao@...italocean.com>
Subject: Re: [PATCH v2 2/2] vdpa: Remove ioctl VHOST_VDPA_SET_CONFIG per spec
 compliance



On 04.09.24 05:38, Jason Wang wrote:
> On Wed, Sep 4, 2024 at 1:15 AM Carlos Bilbao
> <carlos.bilbao.osdev@...il.com> wrote:
>>
>> From: Carlos Bilbao <cbilbao@...italocean.com>
>>
>> Remove invalid ioctl VHOST_VDPA_SET_CONFIG and all its implementations
>> with vdpa_config_ops->set_config(). This is needed per virtio spec
>> requirements; virtio-spec v3.1 Sec 5.1.4 states that "All of the device
>> configuration fields are read-only for the driver."
>>
>> Signed-off-by: Carlos Bilbao <cbilbao@...italocean.com>
> 
> Note that only the config space of the modern device is read only. So
> it should be fine to remove vp_vdpa which only works for modern
> devices.
Just out of curiosity: how will this work for devices that are not
v1.3 compliant but are v1.2 compliant? Or is this true of all devices
except eni?

Thanks,
Dragos
> 
> And for eni, it is a legacy only device, so we should not move the
> set_config there.
> 
> For the rest, we need the acks for those maintainers.
> 
> Thanks
>