| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20240904061755.1467832-1-yangjihong@bytedance.com>
Date: Wed, 4 Sep 2024 14:17:55 +0800
From: Yang Jihong <yangjihong@...edance.com>
To: peterz@...radead.org,
mingo@...hat.com,
acme@...nel.org,
namhyung@...nel.org,
mark.rutland@....com,
alexander.shishkin@...ux.intel.com,
jolsa@...nel.org,
irogers@...gle.com,
adrian.hunter@...el.com,
kan.liang@...ux.intel.com,
james.clark@....com,
linux-perf-users@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: yangjihong@...edance.com
Subject: [PATCH v2] tools lib subcmd: Use array data to save built usage string
commit 230a7a71f922 ("libsubcmd: Fix parse-options memory leak")
free built usage string to solve the memory leak problem,
which causes perf tool to not print subcommands when outputting usage help,
reducing the friendliness of the information.
If use original method of dynamically allocating memory, caller needs to
free the memory in appropriate place. In order to avoid it, use an array
to save built usage string.
Currently, only perf tool uses this function, 128 bytes are enough.
libsubcmd calls scnprintf(), move the build dependency of vsprintf.o from
perf to libsubcmd. Otherwise objtool build will fail (because it indirectly
calls parse_options_subcommand()), see [1]
Before:
# perf sched
Usage: (null)
-D, --dump-raw-trace dump raw trace in ASCII
-f, --force don't complain, do it
-i, --input <file> input file name
-v, --verbose be more verbose (show symbol address, etc)
After:
# perf sched
Usage: perf sched [<options>] {record|latency|map|replay|script|timehist}
-D, --dump-raw-trace dump raw trace in ASCII
-f, --force don't complain, do it
-i, --input <file> input file name
-v, --verbose be more verbose (show symbol address, etc)
Fixes: 230a7a71f922 ("libsubcmd: Fix parse-options memory leak")
Link: https://lore.kernel.org/oe-kbuild-all/202409040112.BKj8VlQT-lkp@intel.com/ # [1]
Signed-off-by: Yang Jihong <yangjihong@...edance.com>
---
Changes since v1:
- Move the build dependency of vsprintf.o from perf to libsubcmd.
tools/lib/subcmd/Build | 5 +++++
tools/lib/subcmd/parse-options.c | 27 +++++++++++++++------------
tools/lib/subcmd/parse-options.h | 10 ++++++++++
tools/perf/util/Build | 5 -----
4 files changed, 30 insertions(+), 17 deletions(-)
diff --git a/tools/lib/subcmd/Build b/tools/lib/subcmd/Build
index ee31288788c1..af832dab00df 100644
--- a/tools/lib/subcmd/Build
+++ b/tools/lib/subcmd/Build
@@ -5,3 +5,8 @@ libsubcmd-y += parse-options.o
libsubcmd-y += run-command.o
libsubcmd-y += sigchain.o
libsubcmd-y += subcmd-config.o
+libsubcmd-y += vsprintf.o
+
+$(OUTPUT)vsprintf.o: ../vsprintf.c FORCE
+ $(call rule_mkdir)
+ $(call if_changed_dep,cc_o_c)
diff --git a/tools/lib/subcmd/parse-options.c b/tools/lib/subcmd/parse-options.c
index 4b60ec03b0bb..1e41a204864a 100644
--- a/tools/lib/subcmd/parse-options.c
+++ b/tools/lib/subcmd/parse-options.c
@@ -633,20 +633,26 @@ int parse_options_subcommand(int argc, const char **argv, const struct option *o
const char *const subcommands[], const char *usagestr[], int flags)
{
struct parse_opt_ctx_t ctx;
- char *buf = NULL;
/* build usage string if it's not provided */
if (subcommands && !usagestr[0]) {
- astrcatf(&buf, "%s %s [<options>] {", subcmd_config.exec_name, argv[0]);
+ int n;
+ static char buf[USAGESTR_BUF_SIZE];
+ int buf_size = sizeof(buf);
- for (int i = 0; subcommands[i]; i++) {
- if (i)
- astrcat(&buf, "|");
- astrcat(&buf, subcommands[i]);
+ n = scnprintf(buf, buf_size, "%s %s [<options>] {",
+ subcmd_config.exec_name, argv[0]);
+
+ for (int i = 0; subcommands[i] && n < buf_size - 1; i++) {
+ n += scnprintf(buf + n, buf_size - n, "%s%s",
+ i ? "|" : "", subcommands[i]);
}
- astrcat(&buf, "}");
+ if (n < buf_size - 1)
+ n += scnprintf(buf + n, buf_size - n, "}");
- usagestr[0] = buf;
+ /* only provided if a complete string is built */
+ if (n < buf_size - 1)
+ usagestr[0] = buf;
}
parse_options_start(&ctx, argc, argv, flags);
@@ -678,10 +684,7 @@ int parse_options_subcommand(int argc, const char **argv, const struct option *o
astrcatf(&error_buf, "unknown switch `%c'", *ctx.opt);
usage_with_options(usagestr, options);
}
- if (buf) {
- usagestr[0] = NULL;
- free(buf);
- }
+
return parse_options_end(&ctx);
}
diff --git a/tools/lib/subcmd/parse-options.h b/tools/lib/subcmd/parse-options.h
index 8e9147358a28..654ba0a2201c 100644
--- a/tools/lib/subcmd/parse-options.h
+++ b/tools/lib/subcmd/parse-options.h
@@ -174,6 +174,16 @@ extern int parse_options(int argc, const char **argv,
const struct option *options,
const char * const usagestr[], int flags);
+/* parse_options_subcommand() will filter out the processed options
+ * and subcommands, leave the non-option argments in argv[].
+ * If usagestr is empty, it will build usage string based on subcommands
+ * in format of "exec_name argv[0] [<options>] {subcommand1|subcomman2|...}".
+ *
+ * NOTE: In order to avoid the caller needing to free memory,
+ * use an 128-bytes array to store the built usage string.
+ * If need to expand the array size, please modify USAGESTR_BUF_SIZE macro.
+ */
+#define USAGESTR_BUF_SIZE 128
extern int parse_options_subcommand(int argc, const char **argv,
const struct option *options,
const char *const subcommands[],
diff --git a/tools/perf/util/Build b/tools/perf/util/Build
index 260cec2f6c0b..14b00a563ab7 100644
--- a/tools/perf/util/Build
+++ b/tools/perf/util/Build
@@ -144,7 +144,6 @@ perf-util-y += help-unknown-cmd.o
perf-util-y += dlfilter.o
perf-util-y += mem-events.o
perf-util-y += mem-info.o
-perf-util-y += vsprintf.o
perf-util-y += units.o
perf-util-y += time-utils.o
perf-util-y += expr-flex.o
@@ -386,10 +385,6 @@ $(OUTPUT)util/hweight.o: ../lib/hweight.c FORCE
$(call rule_mkdir)
$(call if_changed_dep,cc_o_c)
-$(OUTPUT)util/vsprintf.o: ../lib/vsprintf.c FORCE
- $(call rule_mkdir)
- $(call if_changed_dep,cc_o_c)
-
$(OUTPUT)util/list_sort.o: ../lib/list_sort.c FORCE
$(call rule_mkdir)
$(call if_changed_dep,cc_o_c)
--
2.25.1
Powered by blists - more mailing lists