linux-kernel - Re: [PATCH] iommu/amd: Convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cedb5352-8298-4edd-9212-37952cf879b2@amd.com>
Date: Wed, 4 Sep 2024 12:07:23 +0530
From: Vasant Hegde <vasant.hegde@....com>
To: Chen Ni <nichen@...as.ac.cn>, joro@...tes.org,
 suravee.suthikulpanit@....com, will@...nel.org, robin.murphy@....com
Cc: iommu@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu/amd: Convert comma to semicolon

Hi Chen,

On 9/3/2024 12:55 PM, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.

Thanks for the fix. Jason already have same fix as part of his io-pgtable
refactoring series [1].

[1]
https://lore.kernel.org/linux-iommu/0-v2-831cdc4d00f3+1a315-amd_iopgtbl_jgg@nvidia.com/T/#m79d88869627b02eed4b954d31c8b96090f3e0b5c

-Vasant

> 
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
>  drivers/iommu/amd/io_pgtable_v2.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iommu/amd/io_pgtable_v2.c b/drivers/iommu/amd/io_pgtable_v2.c
> index 664e91c88748..67f1fd8fab07 100644
> --- a/drivers/iommu/amd/io_pgtable_v2.c
> +++ b/drivers/iommu/amd/io_pgtable_v2.c
> @@ -373,9 +373,9 @@ static struct io_pgtable *v2_alloc_pgtable(struct io_pgtable_cfg *cfg, void *coo
>  	pgtable->iop.ops.unmap_pages  = iommu_v2_unmap_pages;
>  	pgtable->iop.ops.iova_to_phys = iommu_v2_iova_to_phys;
>  
> -	cfg->pgsize_bitmap = AMD_IOMMU_PGSIZES_V2,
> -	cfg->ias           = ias,
> -	cfg->oas           = IOMMU_OUT_ADDR_BIT_SIZE,
> +	cfg->pgsize_bitmap = AMD_IOMMU_PGSIZES_V2;
> +	cfg->ias           = ias;
> +	cfg->oas           = IOMMU_OUT_ADDR_BIT_SIZE;
>  	cfg->tlb           = &v2_flush_ops;
>  
>  	return &pgtable->iop;