linux-kernel - Re: [PATCH 1/5] clk: meson: Fix an issue with inaccurate hifi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5021173f-8277-4e5f-8c3e-3febcb45e9da@amlogic.com>
Date: Wed, 4 Sep 2024 15:32:40 +0800
From: Chuan Liu <chuan.liu@...ogic.com>
To: xianwei.zhao@...ogic.com
Cc: linux-amlogic@...ts.infradead.org, linux-clk@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] clk: meson: Fix an issue with inaccurate hifi_pll
 frequency


Sorry, The email was sent by mistake, please ignore it.


On 2024/9/4 15:20, chuan.liu@...ogic.com wrote:
> From: Chuan Liu <chuan.liu@...ogic.com>
>
> Some PLLs with fractional multipliers have fractional denominators that
> are fixed to "100000" instead of the previous "(1 << pll->frac.width)".
>
> The hifi_pll for both C3 and S4 supports a fractional multiplier and has
> a fixed fractional denominator of "100000".
>
> Here are the results of the C3-based command tests (already defined
> CLOCK_ALLOW_WRITE_DEBUGFS):
> # echo 491520000 > /sys/kernel/debug/clk/hifi_pll/clk_rate
> # cat /sys/kernel/debug/clk/hifi_pll/clk_rate
> 491520000
> # echo 1 > /sys/kernel/debug/clk/hifi_pll/clk_prepare_enable
> # cat /sys/kernel/debug/meson-clk-msr/clks/hifi_pll_clk
> 491515625       +/-15625Hz
> # devmem 0xfe008100 32
> 0xD00304A3
> # devmem 0xfe008104 32
> 0x00014820
>
> Based on the register information read above, it can be obtained:
> m = 0xA3 = 0d163;
> n = 0x1 = 0d1
> frac = 0x14820 = 0d84000
> od = 0x3 = 0d3
>
> hifi_pll calculates the output frequency:
> calc_rate = xtal_rate / n * (m + (frac / frac_max)) >> od;
> calc_rate = 24000000 / 1 * (163 + (84000 / 100000)) >> 3;
> calc_rate = 491520000
>
> clk_rate, msr_rate, and calc_rate all match.
>
> The test and calculation results of S4 are consistent with those of C3,
> which will not be repeated here.
>
> To: Neil Armstrong <neil.armstrong@...aro.org>
> To: Jerome Brunet <jbrunet@...libre.com>
> To: Michael Turquette <mturquette@...libre.com>
> To: Stephen Boyd <sboyd@...nel.org>
> To: Kevin Hilman <khilman@...libre.com>
> To: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> Cc:  <linux-amlogic@...ts.infradead.org>
> Cc:  <linux-clk@...r.kernel.org>
> Cc:  <linux-arm-kernel@...ts.infradead.org>
> Cc:  <linux-kernel@...r.kernel.org>
> Signed-off-by: Chuan Liu <chuan.liu@...ogic.com>
>
>
> --- b4-submit-tracking ---
> # This section is used internally by b4 prep for tracking purposes.
> {
>    "series": {
>      "revision": 1,
>      "change-id": "20240904-fix_clk-668f7a1a2b16",
>      "prefixes": []
>    }
> }