linux-kernel - Re: [RFC 27/31] objtool: Fix weak symbol detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240904074254.GB4723@noisy.programming.kicks-ass.net>
Date: Wed, 4 Sep 2024 09:42:54 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Josh Poimboeuf <jpoimboe@...nel.org>
Cc: live-patching@...r.kernel.org, linux-kernel@...r.kernel.org,
	x86@...nel.org, Miroslav Benes <mbenes@...e.cz>,
	Petr Mladek <pmladek@...e.com>,
	Joe Lawrence <joe.lawrence@...hat.com>,
	Jiri Kosina <jikos@...nel.org>,
	Marcos Paulo de Souza <mpdesouza@...e.com>,
	Song Liu <song@...nel.org>
Subject: Re: [RFC 27/31] objtool: Fix weak symbol detection

On Tue, Sep 03, 2024 at 08:55:13PM -0700, Josh Poimboeuf wrote:
> On Tue, Sep 03, 2024 at 10:26:45AM +0200, Peter Zijlstra wrote:
> > On Mon, Sep 02, 2024 at 09:00:10PM -0700, Josh Poimboeuf wrote:
> > > @@ -433,9 +433,13 @@ static void elf_add_symbol(struct elf *elf, struct symbol *sym)
> > >  	/*
> > >  	 * Don't store empty STT_NOTYPE symbols in the rbtree.  They
> > >  	 * can exist within a function, confusing the sorting.
> > > +	 *
> > > +	 * TODO: is this still true?
> > 
> > a2e38dffcd93 ("objtool: Don't add empty symbols to the rbtree")
> > 
> > I don't think that changed.
> 
> But see two patches back where I fixed a bug in the insertion of
> zero-length symbols.
> 
> I was thinking that might actually be the root cause of the above
> commit.

Aah, yeah, might be. If we can reproduce the original problem, it should
be verifiable.