| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <875xrbu8uw.fsf@intel.com> Date: Wed, 04 Sep 2024 11:21:59 +0300 From: Jani Nikula <jani.nikula@...el.com> To: Hamza Mahfooz <hamza.mahfooz@....com>, amd-gfx@...ts.freedesktop.org Cc: dri-devel@...ts.freedesktop.org, Alex Deucher <alexander.deucher@....com>, Christian König <christian.koenig@....com>, linux-kernel@...r.kernel.org, Hawking Zhang <Hawking.Zhang@....com>, Hamza Mahfooz <hamza.mahfooz@....com> Subject: Re: [PATCH] drm/amdgpu: enable -Wformat-truncation On Tue, 03 Sep 2024, Hamza Mahfooz <hamza.mahfooz@....com> wrote: > It is enabled by W=1 and amdgpu has a clean build with it enabled. So, > to make sure we block future instances of it from showing up on > our driver, enable it by default for the module. Would prefer enabling it by default across the subsystem [1]. BR, Jani. [1] https://lore.kernel.org/r/cover.1716479340.git.jani.nikula@intel.com > > Signed-off-by: Hamza Mahfooz <hamza.mahfooz@....com> > --- > drivers/gpu/drm/amd/amdgpu/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/Makefile b/drivers/gpu/drm/amd/amdgpu/Makefile > index 34943b866687..64adadb56fd6 100644 > --- a/drivers/gpu/drm/amd/amdgpu/Makefile > +++ b/drivers/gpu/drm/amd/amdgpu/Makefile > @@ -41,6 +41,7 @@ ccflags-y := -I$(FULL_AMD_PATH)/include/asic_reg \ > > # Locally disable W=1 warnings enabled in drm subsystem Makefile > subdir-ccflags-y += -Wno-override-init > +subdir-ccflags-y += $(call cc-option, -Wformat-truncation) > subdir-ccflags-$(CONFIG_DRM_AMDGPU_WERROR) += -Werror > > amdgpu-y := amdgpu_drv.o -- Jani Nikula, Intel
Powered by blists - more mailing lists