linux-kernel - Re: [PATCH] wifi: mt76: mt7925: convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f2380ad1-f1d1-41c1-b00e-782f2c1937fc@gmail.com>
Date: Wed, 4 Sep 2024 10:36:46 +0200
From: Matthias Brugger <matthias.bgg@...il.com>
To: Chen Ni <nichen@...as.ac.cn>, nbd@....name, lorenzo@...nel.org,
 ryder.lee@...iatek.com, shayne.chen@...iatek.com, sean.wang@...iatek.com,
 kvalo@...nel.org, angelogioacchino.delregno@...labora.com,
 deren.wu@...iatek.com, mingyen.hsieh@...iatek.com
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] wifi: mt76: mt7925: convert comma to semicolon



On 04/09/2024 09:52, Chen Ni wrote:
> Replace comma between expressions with semicolons.
> 
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
> 
> Found by inspection.
> No functional change intended.
> Compile tested only.
> 
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>

Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>

> ---
>   drivers/net/wireless/mediatek/mt76/mt7925/mcu.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
> index 9dc22fbe25d3..82c5a8def344 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
> @@ -2171,12 +2171,12 @@ void mt7925_mcu_bss_rlm_tlv(struct sk_buff *skb, struct mt76_phy *phy,
>   
>   	tlv = mt76_connac_mcu_add_tlv(skb, UNI_BSS_INFO_RLM, sizeof(*req));
>   	req = (struct bss_rlm_tlv *)tlv;
> -	req->control_channel = chandef->chan->hw_value,
> -	req->center_chan = ieee80211_frequency_to_channel(freq1),
> -	req->center_chan2 = ieee80211_frequency_to_channel(freq2),
> -	req->tx_streams = hweight8(phy->antenna_mask),
> -	req->ht_op_info = 4, /* set HT 40M allowed */
> -	req->rx_streams = hweight8(phy->antenna_mask),
> +	req->control_channel = chandef->chan->hw_value;
> +	req->center_chan = ieee80211_frequency_to_channel(freq1);
> +	req->center_chan2 = ieee80211_frequency_to_channel(freq2);
> +	req->tx_streams = hweight8(phy->antenna_mask);
> +	req->ht_op_info = 4; /* set HT 40M allowed */
> +	req->rx_streams = hweight8(phy->antenna_mask);
>   	req->band = band;
>   
>   	switch (chandef->width) {