linux-kernel - Re: [PATCH V6 net-next 03/11] net: hibmcge: Add mdio and hardware configuration supported in this module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a86835c6-24d8-4f04-979e-a77d35776467@huawei.com>
Date: Wed, 4 Sep 2024 09:34:45 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <shaojijie@...wei.com>, Paolo Abeni <pabeni@...hat.com>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <shenjian15@...wei.com>,
	<wangpeiyang1@...wei.com>, <liuyonglong@...wei.com>, <chenhao418@...wei.com>,
	<sudongming1@...wei.com>, <xujunsheng@...wei.com>, <shiyongbang@...wei.com>,
	<libaihan@...wei.com>, <andrew@...n.ch>, <jdamato@...tly.com>,
	<horms@...nel.org>, <jonathan.cameron@...wei.com>,
	<shameerali.kolothum.thodi@...wei.com>, <salil.mehta@...wei.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V6 net-next 03/11] net: hibmcge: Add mdio and hardware
 configuration supported in this module


on 2024/9/4 1:44, Jakub Kicinski wrote:
> On Tue, 3 Sep 2024 20:13:58 +0800 Jijie Shao wrote:
>>>> +{
>>>> +    struct hbg_priv *priv = netdev_priv(netdev);
>>>> +    struct phy_device *phydev = priv->mac.phydev;
>>> Minor nit: please respect the reverse x-mas tree order
>> Here, I need to get the *priv first, so I'm not following the reverse x-mas tree order here.
>> I respect the reverse x-mas tree order everywhere else.
> In this case you should move the init into the body of the function.

ok， Thanks! Jijie Shao