[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <25f8a244-45c4-44bb-a0c1-37c057dd8d7b@gmail.com>
Date: Wed, 4 Sep 2024 10:47:00 +0200
From: Matthias Brugger <matthias.bgg@...il.com>
To: Liu Jing <liujing@...s.chinamobile.com>, lgirdwood@...il.com
Cc: broonie@...nel.org, perex@...ex.cz,
angelogioacchino.delregno@...labora.com, linus.walleij@...aro.org,
bartosz.golaszewski@...aro.org, kuninori.morimoto.gx@...esas.com,
linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] ASoC: mediatek: mt2701-cs42448: Optimize redundant code
in mt2701_cs42448_machine_probe
On 03/09/2024 11:36, Liu Jing wrote:
> Utilize the defined parameter 'dev' to make the code cleaner.
>
> Signed-off-by: Liu Jing <liujing@...s.chinamobile.com>
Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>
> ---
> sound/soc/mediatek/mt2701/mt2701-cs42448.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/sound/soc/mediatek/mt2701/mt2701-cs42448.c b/sound/soc/mediatek/mt2701/mt2701-cs42448.c
> index 1262e8a1bc9a..4974b0536b7b 100644
> --- a/sound/soc/mediatek/mt2701/mt2701-cs42448.c
> +++ b/sound/soc/mediatek/mt2701/mt2701-cs42448.c
> @@ -329,10 +329,10 @@ static int mt2701_cs42448_machine_probe(struct platform_device *pdev)
> int ret;
> int i;
> struct device_node *platform_node, *codec_node, *codec_node_bt_mrg;
> + struct device *dev = &pdev->dev;
> struct mt2701_cs42448_private *priv =
> - devm_kzalloc(&pdev->dev, sizeof(struct mt2701_cs42448_private),
> + devm_kzalloc(dev, sizeof(struct mt2701_cs42448_private),
> GFP_KERNEL);
> - struct device *dev = &pdev->dev;
> struct snd_soc_dai_link *dai_link;
>
> if (!priv)
> @@ -341,7 +341,7 @@ static int mt2701_cs42448_machine_probe(struct platform_device *pdev)
> platform_node = of_parse_phandle(pdev->dev.of_node,
> "mediatek,platform", 0);
> if (!platform_node) {
> - dev_err(&pdev->dev, "Property 'platform' missing or invalid\n");
> + dev_err(dev, "Property 'platform' missing or invalid\n");
> return -EINVAL;
> }
> for_each_card_prelinks(card, i, dai_link) {
> @@ -355,7 +355,7 @@ static int mt2701_cs42448_machine_probe(struct platform_device *pdev)
> codec_node = of_parse_phandle(pdev->dev.of_node,
> "mediatek,audio-codec", 0);
> if (!codec_node) {
> - dev_err(&pdev->dev,
> + dev_err(dev,
> "Property 'audio-codec' missing or invalid\n");
> return -EINVAL;
> }
> @@ -368,7 +368,7 @@ static int mt2701_cs42448_machine_probe(struct platform_device *pdev)
> codec_node_bt_mrg = of_parse_phandle(pdev->dev.of_node,
> "mediatek,audio-codec-bt-mrg", 0);
> if (!codec_node_bt_mrg) {
> - dev_err(&pdev->dev,
> + dev_err(dev,
> "Property 'audio-codec-bt-mrg' missing or invalid\n");
> return -EINVAL;
> }
> @@ -377,7 +377,7 @@ static int mt2701_cs42448_machine_probe(struct platform_device *pdev)
>
> ret = snd_soc_of_parse_audio_routing(card, "audio-routing");
> if (ret) {
> - dev_err(&pdev->dev, "failed to parse audio-routing: %d\n", ret);
> + dev_err(dev, "failed to parse audio-routing: %d\n", ret);
> return ret;
> }
>
> @@ -395,10 +395,10 @@ static int mt2701_cs42448_machine_probe(struct platform_device *pdev)
>
> snd_soc_card_set_drvdata(card, priv);
>
> - ret = devm_snd_soc_register_card(&pdev->dev, card);
> + ret = devm_snd_soc_register_card(dev, card);
>
> if (ret)
> - dev_err(&pdev->dev, "%s snd_soc_register_card fail %d\n",
> + dev_err(dev, "%s snd_soc_register_card fail %d\n",
> __func__, ret);
> return ret;
> }
Powered by blists - more mailing lists