linux-kernel - Re: [PATCH net-next v10 11/13] net: phy: add driver for built-in 2.5G ethernet PHY on MT7988

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38189661f30032715783e8860318fe9e50258e47.camel@mediatek.com>
Date: Wed, 4 Sep 2024 08:49:50 +0000
From: SkyLake Huang (黃啟澤)
	<SkyLake.Huang@...iatek.com>
To: "andrew@...n.ch" <andrew@...n.ch>
CC: "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "linux@...linux.org.uk"
	<linux@...linux.org.uk>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"dqfext@...il.com" <dqfext@...il.com>,
	Steven Liu (劉人豪) <steven.liu@...iatek.com>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>, "davem@...emloft.net"
	<davem@...emloft.net>, "hkallweit1@...il.com" <hkallweit1@...il.com>,
	"daniel@...rotopia.org" <daniel@...rotopia.org>,
	"angelogioacchino.delregno@...labora.com"
	<angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH net-next v10 11/13] net: phy: add driver for built-in 2.5G
 ethernet PHY on MT7988

On Wed, 2024-08-21 at 17:49 +0800, SkyLake.Huang wrote:
> On Fri, 2024-08-09 at 16:17 +0200, Andrew Lunn wrote:
> >  	 
> > External email : Please do not click links or open attachments
> > until
> > you have verified the sender or the content.
> >  > +static int mt798x_2p5ge_phy_config_aneg(struct phy_device
> > *phydev)
> > > +{
> > > +bool changed = false;
> > > +u32 adv;
> > > +int ret;
> > > +
> > > +/* In fact, if we disable autoneg, we can't link up correctly:
> > > + * 2.5G/1G: Need AN to exchange master/slave information.
> > > + * 100M/10M: Without AN, link starts at half duplex (According
> > > to
> > > + *           IEEE 802.3-2018), which this phy doesn't support.
> > > + */
> > > +if (phydev->autoneg == AUTONEG_DISABLE)
> > > +return -EOPNOTSUPP;
> > 
> > I assume you have seen Russells patches in this area. Please could
> > you
> > test and review them. Depending on which gets merged, you might
> > need
> > to come back and clean this up later.
> > 
> >    Andrew
> 
> Yes I've seen Russells' patch which forces AN on for speed >= 1G.
> Could I send another patch to clean this up? This patchset is sent a
> month ago. I need some time to rebuild my testing environment.
> 
> BRs,
> Sky

Gentle ping.

BRs,
Sky