[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d00f2003-fd4c-4841-87e4-bb977733d969@amlogic.com>
Date: Wed, 4 Sep 2024 17:16:47 +0800
From: Keke Li <keke.li@...ogic.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-media@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, kieran.bingham@...asonboard.com,
laurent.pinchart@...asonboard.com, dan.scally@...asonboard.com
Subject: Re: [PATCH 4/9] media: platform: Add c3 mipi adapter driver
Hi Krzysztof,
Thanks for your reply.
On 2024/9/3 22:12, Krzysztof Kozlowski wrote:
> [You don't often get email from krzk@...nel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> [ EXTERNAL EMAIL ]
>
> On 03/09/2024 08:57, Keke Li via B4 Relay wrote:
>> From: Keke Li <keke.li@...ogic.com>
>>
>> This driver mainly responsible for organizing
>> MIPI data and sending raw data to ISP pipeline.
>>
>> Signed-off-by: Keke Li <keke.li@...ogic.com>
> ...
>
>> +static int c3_mipi_adap_probe(struct platform_device *pdev)
>> +{
>> + struct device *dev = &pdev->dev;
>> + struct adap_device *adap;
>> + int ret;
>> +
>> + adap = devm_kzalloc(dev, sizeof(*adap), GFP_KERNEL);
>> + if (!adap)
>> + return -ENOMEM;
>> +
>> + adap->info = of_device_get_match_data(dev);
>> + adap->dev = dev;
>> +
>> + ret = c3_mipi_adap_ioremap_resource(adap);
>> + if (ret) {
>> + dev_err(dev, "Failed to ioremap resource: %d\n", ret);
>> + return ret;
>> + }
>> +
>> + ret = c3_mipi_adap_configure_clocks(adap);
>> + if (ret) {
>> + dev_err(dev, "Failed to configure clocks: %d\n", ret);
> All your patches repeat the same patterns, so all my comments apply to
> each patch.
OK, I will modify the code according to your comments.
Thanks again.
>
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists