linux-kernel - Re: [PATCH v2 13/21] dt-bindings: pinctrl: Add SA8255p TLMM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <172541460656.3237041.12121704663662726692.robh@kernel.org>
Date: Tue, 03 Sep 2024 20:50:06 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Nikunj Kela <quic_nkela@...cinc.com>
Cc: devicetree@...r.kernel.org, cristian.marussi@....com, 
 rui.zhang@...el.com, linux-spi@...r.kernel.org, lee@...nel.org, 
 krzk+dt@...nel.org, will@...nel.org, linux-arm-msm@...r.kernel.org, 
 linus.walleij@...aro.org, joro@...tes.org, linux-kernel@...r.kernel.org, 
 robin.murphy@....com, quic_psodagud@...cinc.com, conor+dt@...nel.org, 
 kernel@...cinc.com, sudeep.holla@....com, linux-serial@...r.kernel.org, 
 linux-i2c@...r.kernel.org, herbert@...dor.apana.org.au, 
 konradybcio@...nel.org, jassisinghbrar@...il.com, 
 linux-gpio@...r.kernel.org, linux-pm@...r.kernel.org, andersson@...nel.org, 
 lukasz.luba@....com, iommu@...ts.linux.dev, linux-watchdog@...r.kernel.org, 
 broonie@...nel.org, rafael@...nel.org, davem@...emloft.net, 
 arm-scmi@...r.kernel.org, thara.gopinath@...il.com, viresh.kumar@...aro.org, 
 linux@...ck-us.net, amitk@...nel.org, wim@...ux-watchdog.org, 
 andi.shyti@...nel.org, linux-arm-kernel@...ts.infradead.org, 
 tglx@...utronix.de, linux-crypto@...r.kernel.org
Subject: Re: [PATCH v2 13/21] dt-bindings: pinctrl: Add SA8255p TLMM


On Tue, 03 Sep 2024 15:02:32 -0700, Nikunj Kela wrote:
> Add compatible for TLMM block representing support on SA8255p.
> 
> SA8255p uses the same TLMM block as SA8775p however the ownership
> of pins are split between Firmware VM and Linux VM on SA8255p. For
> example, pins used by UART are owned and configured by Firmware VM
> while pins used by ethernet are owned and configured by Linux VM.
> Therefore, adding a sa8255p specific compatible to mark the difference.
> 
> Signed-off-by: Nikunj Kela <quic_nkela@...cinc.com>
> ---
>  .../devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml    | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml:22:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
./Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml:23:11: [warning] wrong indentation: expected 12 but found 10 (indentation)
./Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml:26:9: [warning] wrong indentation: expected 10 but found 8 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240903220240.2594102-14-quic_nkela@quicinc.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.