[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <tencent_DD4C79766E502D6D6E1494B4E88AED6ECE0A@qq.com>
Date: Wed, 4 Sep 2024 08:20:29 +0800
From: Edward Adam Davis <eadavis@...com>
To: syzbot+f3a31fb909db9b2a5c4d@...kaller.appspotmail.com
Cc: linux-kernel@...r.kernel.org
Subject: Re: [syzbot] [mptcp?] KASAN: slab-use-after-free Read in __timer_delete_sync
entry need to be protected by pm.lock.
#syz test
Upstream-Status: Pending
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index 3e4ad801786f..d4cbf7dcf983 100644
--- a/net/mptcp/pm_netlink.c
+++ b/net/mptcp/pm_netlink.c
@@ -1430,8 +1430,10 @@ static bool remove_anno_list_by_saddr(struct mptcp_sock *msk,
entry = mptcp_pm_del_add_timer(msk, addr, false);
if (entry) {
+ spin_lock_bh(&msk->pm.lock);
list_del(&entry->list);
kfree(entry);
+ spin_unlock_bh(&msk->pm.lock);
return true;
}
Powered by blists - more mailing lists