linux-kernel - Re: [PATCH] mips: Remove posix_types.h include from sigcontext.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f47376d9dfc174fc6eeb29ee45c67413ecc1feb6.camel@xry111.site>
Date: Wed, 04 Sep 2024 18:02:49 +0800
From: Xi Ruoyao <xry111@...111.site>
To: "Maciej W. Rozycki" <macro@...am.me.uk>
Cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de>, Jiaxun Yang
	 <jiaxun.yang@...goat.com>, linux-mips@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mips: Remove posix_types.h include from sigcontext.h

On Wed, 2024-09-04 at 03:06 +0100, Maciej W. Rozycki wrote:
> -#include <linux/types.h>
> -
>  /*
>   * Keep this struct definition in sync with the sigcontext fragment
>   * in arch/mips/tools/offset.c
> @@ -66,6 +64,9 @@ struct sigcontext {
>  };
>  
>  #ifdef __KERNEL__
> +
> +#include <linux/posix_types.h>
> +
>  struct sigcontext32 {
>  	__u32	sc_regmask;		/* Unused */
>  	__u32	sc_status;
> 
> so not without explanation and clearly to address a userland compilation 
> issue.  It seems that the original directive should have just been moved 
> into the __KERNEL__ part without changing the file included though.

Yes, I just mean *changing* the include file is not explained and it
seems an error.  I'm not familiar with ancient kernels but AFAIK for
using __u32 etc. we should use linux/types.h since Linux 1.2.

Moving the include into #ifdef __KERNEL__ makes sense to me.

-- 
Xi Ruoyao <xry111@...111.site>
School of Aerospace Science and Technology, Xidian University