linux-kernel - Re: [PATCH 00/19] Add initial support for QCS8300

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3535a897-8708-463d-b931-fa344a967f18@kernel.org>
Date: Wed, 4 Sep 2024 12:19:19 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Bjorn Andersson <andersson@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: Kishon Vijay Abraham I <kishon@...nel.org>,
 Jassi Brar <jassisinghbrar@...il.com>,
 Mathieu Poirier <mathieu.poirier@...aro.org>, Will Deacon <will@...nel.org>,
 Jingyi Wang <quic_jingyw@...cinc.com>,
 Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
 Thomas Gleixner <tglx@...utronix.de>, Das Srinagesh
 <quic_gurus@...cinc.com>, Ulf Hansson <ulf.hansson@...aro.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Andy Gross <agross@...nel.org>,
 Bart Van Assche <bvanassche@....org>, linux-arm-msm@...r.kernel.org,
 Robert Marko <robimarko@...il.com>, Joerg Roedel <joro@...tes.org>,
 linux-remoteproc@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Alim Akhtar <alim.akhtar@...sung.com>,
 linux-phy@...ts.infradead.org, linux-scsi@...r.kernel.org,
 linux-pm@...r.kernel.org,
 Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
 linux-arm-kernel@...ts.infradead.org,
 Catalin Marinas <catalin.marinas@....com>, iommu@...ts.linux.dev,
 Xin Liu <quic_liuxin@...cinc.com>, Shazad Hussain
 <quic_shazhuss@...cinc.com>, Tingguo Cheng <quic_tingguoc@...cinc.com>,
 Zhenhua Huang <quic_zhenhuah@...cinc.com>,
 Kyle Deng <quic_chunkaid@...cinc.com>,
 Raviteja Laggyshetty <quic_rlaggysh@...cinc.com>, Lee Jones
 <lee@...nel.org>, Robin Murphy <robin.murphy@....com>,
 Avri Altman <avri.altman@....com>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Vinod Koul <vkoul@...nel.org>
Subject: Re: [PATCH 00/19] Add initial support for QCS8300

On 04/09/2024 11:34, Krzysztof Kozlowski wrote:
> On 04/09/2024 10:33, Jingyi Wang wrote:
>> Add initial support for QCS8300 SoC and QCS8300 RIDE board.
>>
>> This revision brings support for:
>> - CPUs with cpu idle
>> - interrupt-controller with PDC wakeup support
>> - gcc
>> - TLMM
>> - interconnect
>> - qup with uart
>> - smmu
>> - pmic
>> - ufs
>> - ipcc
>> - sram
>> - remoteprocs including ADSP,CDSP and GPDSP
>>
>> Signed-off-by: Jingyi Wang <quic_jingyw@...cinc.com>
>> ---
>> patch series organized as:
>> - 1-2: remoteproc binding and driver
>> - 3-5: ufs binding and driver
>> - 6-7: rpmhpd binding and driver
>> - 8-15: bindings for other components found on the SoC
> 
> Limit your CC list. I found like 8 unnecessary addresses for already
> huge Cc list. Or organize your patches per subsystem, as we usually expect.
> 
>> - 16-19: changes to support the device tree
>>
>> dependencies:
>> tlmm: https://lore.kernel.org/linux-arm-msm/20240819064933.1778204-1-quic_jingyw@quicinc.com/
>> gcc: https://lore.kernel.org/all/20240820-qcs8300-gcc-v1-0-d81720517a82@quicinc.com/
>> interconnect: https://lore.kernel.org/linux-arm-msm/20240827151622.305-1-quic_rlaggysh@quicinc.com/
> 
> Why? UFS cannot depend on pinctrl for example.
> 
> This blocks testing and merging.
> 
> Please organize properly (so decouple) your patches, so that there is no
> fake dependency.

Let me also add here one more thought. That's like fourth or fifth
QCS/SA patchset last two weeks from Qualcomm and they repeat the same
mistakes. Not correctly organized, huge cc list, same problems with
bindings or drivers.

I am giving much more comments to fix than review/ack tags.

I am not going to review this. I will also slow down with reviewing
other Qualcomm patches. Why? Because you post simultaneously, apparently
you do not learn from other review, so I have to keep repeating the same.

I am overwhelmed with this, so please expect two week review time from me.

Best regards,
Krzysztof