linux-kernel - Re: [PATCH v5 7/7] iio: pressure: bmp280: Move bmp085 interrupt to new configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240904102925.GC44250@vamoiridPC>
Date: Wed, 4 Sep 2024 12:29:25 +0200
From: Vasileios Amoiridis <vassilisamir@...il.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Vasileios Amoiridis <vassilisamir@...il.com>, jic23@...nel.org,
	lars@...afoo.de, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, ang.iglesiasg@...il.com,
	linus.walleij@...aro.org, biju.das.jz@...renesas.com,
	javier.carrasco.cruz@...il.com, semen.protsenko@...aro.org,
	579lpy@...il.com, ak@...klinger.de, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	christophe.jaillet@...adoo.fr
Subject: Re: [PATCH v5 7/7] iio: pressure: bmp280: Move bmp085 interrupt to
 new configuration

On Tue, Sep 03, 2024 at 05:39:47PM +0300, Andy Shevchenko wrote:
> On Mon, Sep 02, 2024 at 08:42:22PM +0200, Vasileios Amoiridis wrote:
> > This commit intends to add the old BMP085 sensor to the new IRQ interface
> > of the driver for consistence. No functional changes intended.
> > 
> > The BMP085 sensor is equivalent with the BMP180 with the only difference of
> > BMP085 having an extra interrupt pin to inform about an End of Conversion.
> 
> This one also LGTM,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 

Thanks a lot for this!

> ...
> 
> > -	int ret;
> > +	int ret, irq;
> 
> I'm not fan of such a churn, meaning a new variable just on the new line to
> make diff less noisy, but it's not a big deal at all.
> 

I understand why, but at some point someone else would have come and make
a new commit probably with "organise/cleanup variable assignments"...

> -- 
> With Best Regards,
> Andy Shevchenko
> 
> 

Cheers,
Vasilis